Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend source generator diagnostics in several scenarios #141

Merged
merged 19 commits into from
Mar 15, 2022

Conversation

Sergio0694
Copy link
Member

@Sergio0694 Sergio0694 commented Mar 12, 2022

Closes #140
Closes #142
Closes #143
Closes #145
Closes #146
Closes #147

@Sergio0694 Sergio0694 added improvements ✨ Improvements to an existing functionality next preview ✈️ This changes will be available in the upcoming preview priority 🚩 An issue or change that has priority mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Mar 12, 2022
@Sergio0694 Sergio0694 assigned Arlodotexe and unassigned Arlodotexe Mar 12, 2022
@Sergio0694 Sergio0694 force-pushed the dev/observable-property-name-clash-diagnostics branch from 15b6ca4 to feecbb4 Compare March 12, 2022 15:15
@Sergio0694 Sergio0694 marked this pull request as draft March 13, 2022 02:26
@Sergio0694 Sergio0694 marked this pull request as ready for review March 13, 2022 03:13
@Sergio0694 Sergio0694 force-pushed the dev/observable-property-name-clash-diagnostics branch from 22ed27d to e1f7cff Compare March 13, 2022 12:46
@Sergio0694 Sergio0694 force-pushed the dev/observable-property-name-clash-diagnostics branch from e1f7cff to 31f5c95 Compare March 13, 2022 14:15
@Sergio0694 Sergio0694 marked this pull request as draft March 13, 2022 17:12
@Sergio0694 Sergio0694 changed the title Add diagnostics for name collision for [ObservableProperty] Extend source generator diagnostics in several scenarios Mar 13, 2022
@Sergio0694 Sergio0694 force-pushed the dev/observable-property-name-clash-diagnostics branch from 38927de to b632429 Compare March 13, 2022 18:37
@Sergio0694 Sergio0694 marked this pull request as ready for review March 13, 2022 19:07
@Sergio0694 Sergio0694 merged commit 65e1767 into main Mar 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/observable-property-name-clash-diagnostics branch March 15, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvements ✨ Improvements to an existing functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit next preview ✈️ This changes will be available in the upcoming preview priority 🚩 An issue or change that has priority
Projects
None yet
2 participants