-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend source generator diagnostics in several scenarios #141
Merged
Sergio0694
merged 19 commits into
main
from
dev/observable-property-name-clash-diagnostics
Mar 15, 2022
Merged
Extend source generator diagnostics in several scenarios #141
Sergio0694
merged 19 commits into
main
from
dev/observable-property-name-clash-diagnostics
Mar 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
added
improvements ✨
Improvements to an existing functionality
next preview ✈️
This changes will be available in the upcoming preview
priority 🚩
An issue or change that has priority
mvvm-toolkit 🧰
Issues/PRs for the MVVM Toolkit
labels
Mar 12, 2022
Sergio0694
force-pushed
the
dev/observable-property-name-clash-diagnostics
branch
from
March 12, 2022 15:15
15b6ca4
to
feecbb4
Compare
Sergio0694
force-pushed
the
dev/observable-property-name-clash-diagnostics
branch
from
March 13, 2022 12:46
22ed27d
to
e1f7cff
Compare
Sergio0694
force-pushed
the
dev/observable-property-name-clash-diagnostics
branch
from
March 13, 2022 14:15
e1f7cff
to
31f5c95
Compare
Sergio0694
changed the title
Add diagnostics for name collision for [ObservableProperty]
Extend source generator diagnostics in several scenarios
Mar 13, 2022
Sergio0694
force-pushed
the
dev/observable-property-name-clash-diagnostics
branch
from
March 13, 2022 18:37
38927de
to
b632429
Compare
Arlodotexe
approved these changes
Mar 15, 2022
CommunityToolkit.Mvvm.SourceGenerators/ComponentModel/ObservablePropertyGenerator.Execute.cs
Outdated
Show resolved
Hide resolved
delete-merged-branch
bot
deleted the
dev/observable-property-name-clash-diagnostics
branch
March 15, 2022 19:26
14 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvements ✨
Improvements to an existing functionality
mvvm-toolkit 🧰
Issues/PRs for the MVVM Toolkit
next preview ✈️
This changes will be available in the upcoming preview
priority 🚩
An issue or change that has priority
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #140
Closes #142
Closes #143
Closes #145
Closes #146
Closes #147