Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add diagnostic for [AlsoNotifyChangeFor] on invalid targets #143

Closed
Sergio0694 opened this issue Mar 13, 2022 · 2 comments · Fixed by #141
Closed

Add diagnostic for [AlsoNotifyChangeFor] on invalid targets #143

Sergio0694 opened this issue Mar 13, 2022 · 2 comments · Fixed by #141
Assignees
@Sergio0694
Labels
improvements ✨ Improvements to an existing functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit next preview ✈️ This changes will be available in the upcoming preview priority 🚩 An issue or change that has priority

Comments

@Sergio0694
Copy link
Member

Sergio0694 commented Mar 13, 2022 •
edited
Loading

Repro:

public partial class MyViewModel : ObservableObject
{
    [ObservableProperty]
    [AlsoNotifyChangeFor("FooBarBaz")]
    public int number;
}

Same issue with null, not handled properly either (seems to just be ignored).
@Sergio0694 Sergio0694 added improvements ✨ Improvements to an existing functionality next preview ✈️ This changes will be available in the upcoming preview priority 🚩 An issue or change that has priority mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Mar 13, 2022
@Sergio0694 Sergio0694 self-assigned this Mar 13, 2022
@Sergio0694 Sergio0694 mentioned this issue Mar 13, 2022
Merged
@Arlodotexe
Copy link
Member

@Sergio0694 Looks like there's a mistake in your repro description here, possibly a copy/paste that didn't get changed?

@Sergio0694
Copy link
Member Author

Ah, yup, copy paste error, thanks! Fixed 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sergio0694 Sergio0694

Labels
improvements ✨ Improvements to an existing functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit next preview ✈️ This changes will be available in the upcoming preview priority 🚩 An issue or change that has priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extend source generator diagnostics in several scenarios CommunityToolkit/dotnet
2 participants
@Arlodotexe @Sergio0694