Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostics and skip duplicate generated types #146

Closed
Sergio0694 opened this issue Mar 13, 2022 · 0 comments · Fixed by #141
Closed

Add diagnostics and skip duplicate generated types #146

Sergio0694 opened this issue Mar 13, 2022 · 0 comments · Fixed by #141
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit next preview ✈️ This changes will be available in the upcoming preview priority 🚩 An issue or change that has priority

Comments

@Sergio0694
Copy link
Member

Right now some type attributes don't emit all necessary diagnostics and can result in duplicate generation.
For instance:

[ObservableObject]
partial class A
{
}

[ObservableObject]
partial class B : A
{
}
@Sergio0694 Sergio0694 added bug 🐛 An unexpected issue that highlights incorrect behavior next preview ✈️ This changes will be available in the upcoming preview priority 🚩 An issue or change that has priority mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit next preview ✈️ This changes will be available in the upcoming preview priority 🚩 An issue or change that has priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant