-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After upgrading "Microsoft.Toolkit.Uwp.UI.Lottie 6.0.0", using "Windows App Cert Kit" general metadata correctness verification failed #214
After upgrading "Microsoft.Toolkit.Uwp.UI.Lottie 6.0.0", using "Windows App Cert Kit" general metadata correctness verification failed #214
Comments
This issue has been marked as "needs attention 👋" due to no activity for 15 days. Please triage the issue so the fix can be established. |
Can anyone help me? |
FYI @simeoncran |
@KevinZjYang sorry to see that this wasn't given attention back in January. Did you ever try submitting despite the WACK error? We've noticed that the WACK can give false positives that the store doesn't care about. |
I'm having the same issue on my last store submission:
|
@simeoncran the above post from @jeremiethibeault failed at the store submission, so it's not a false positive :/ Full code is available here https://github.com/unoplatform/uno.ch9 |
Thanks @MatFillion and @jeremiethibeault. We are looking into this and will report back here. |
@MatFillion and @jeremiethibeault. I'm told that there are known issues with how VS2017 packaged NuGet metadata that would explain what you're seeing. Can you upgrade to the latest VS2019? |
Hey @simeoncran, I'm using VS2019 16.5.1. Not sure if the issue should still be applicable on this version. I can try on the latest version to see if it fixes the issue. Let me know if there is anything else I can try. I will also check the local WACK test result if I see the same error message, would be easier to debug that. Thanks! |
16.6.2 is the latest version. When I loaded your solution VS required that it first upgrade the projects. I wonder if that's a hint. |
I was able to reproduce the issue locally on VS 16.6.2 I simply created the app bundles using the built-in publish feature of VS for UWP then I ran the WACK test locally which gave me the same result as on the store.
These are the specs App Architecture: |
We have a local repro now. I still don't understand what is triggering it, but we're tracking down the experts and will keep this thread updated. |
The issue is caused by the build not including Microsoft.UI.Xaml.winmd in the app package. You can check that by looking at the winmd files that get packaged into your .msix. As a result WACK doesn't find the references to IAnimatedVisualPlayer and IDynamicAnimatedVisualPlayer. We are looking into why that's happening. EDIT: actually, the winmd is only missing from the sideload (MSIXBUNDLE) builds. The store builds (MSIXUPLOAD) have the MIcrosoft.UI.Xaml.winmd files. Usually you'd submit the MSIXUPLOAD files, but there are some circumstances where MSIXBUNDLE are needed in the store (has to do with corporate signing or something). @jeremiethibeault are you building MSIXBUNDLE (sideloading) or MSIXUPLOAD (store uploading) files? |
@simeoncran That's interesting, I'm building MSIXUPLOAD files through Visual Studio > Publish > Create app packages (the app is associated to the Microsoft Store) The package I've submitted to the store is the MSIXUPLOAD one. |
I confirmed that the Microsoft.UI.Xaml.winmd file is inside .msixupload > .msixbundle > x64.msix > WinMetadata |
Thank you, that's very helpful. Will keep you informed. |
Hi @jeremiethibeault, this issue is taking longer than expected. I don't want you to be blocked till we figure this out, so I had asked for an exception to this rule for your app (Uno Ch9) and the exception is in place now. Please try submitting the package and let us know if you re able to do so. I ll keep you posted as we make progress in the actual issue. Thank you for your patience. |
Hey thanks @ajbennet, I submitted the app without the Lottie animation for now but I will take a look at resubmitting it with it. Have a good day |
We've been investigating this issue. The root cause appears to be an issue in the certification tests. There's a mismatch between how the tools bundle metadata in store submission packages and how the tests search for that data, specifically in the case where metadata is provided by framework packages. I'm glad @ajbennet was able to provide a workaround while we determine how to fix this issue. |
It's still happening BTW |
@matthewacme - can you give me some details and I'll see what I can do. No promises because I'm not really involved in the solution, but I can at least try to get your issue solved before this gets fixed for everyone. |
Thanks! I can also confirm that using Microsft.UI.Xams version 2.5.0-prerelease.200812001 also fixed the issue. |
@nishitha-burman , I am using XAML Island with a WPF App. I've added the
I cannot try the 2.5.0-prerelease suggested by @under3415 because it will create 17 other Build errors in my case. An example from the 17 errors: If I use the following NuGet packages, it will build but fail the metadata test as mentioned above: |
@mentorfloat apologies for the delayed reply, were you able to resolve the issue? |
No, I ended up removing Lottie entirely and instead created custom UserControl containing Key-Frame Animations. |
The issue was resolved in Microsoft.UI.XAML 2.5.0-prerelease.201202003, but has re-appeared in stable release v2.5.0 :-( |
Hi @under3415, Does this issue appear in stable release v2.5.0 even with the workaround? |
Hi It was working fine in pre-release without a workaround. Regards |
@under3415 the WinUI pre-release and the release packages are built differently. FYT @ranjeshj |
If things are done differently for production release, doesn't that defy the purpose of pre-release testing? |
If you hit this issue while trying to publish your app please raise a support ticket on the store while we look into this issue. You can raise a ticket by doing the following:
Thank you! |
WACK expects to be able to find WinMDs for type resolution purposes in the root of the AppX, but when WinUI 2 is referenced via framework package, the WinMD is instead placed in a WinMetadata subdirectory. As a result, applications that reference nuget packages with references to WinUI 2, WACK certification fails. I'm not sure whether placing the WinMD file in that directory is still needed, so to work around this issue in the safest manner, this adds an additional build target that places the WinMD where WACK certification needs it to be. An example of an issue that will be resolved by this fix: CommunityToolkit/Lottie-Windows#214
Fix is checked into the WinUI 2 repo, should be fixed in 2.6. |
After ugrading to latest version facing the below issue. |
Hi @rajeshangappan, Thank you for reaching out. Which version of WinUI and Lottie are you using? |
Hi
|
Hi @under3415, are you getting the same exception mentioned here #214 (comment) when using the latest versions of WinUI and Lottie? |
No, I am getting "metadata correctness test" error. I thought this bug is about that... |
Yes both #405 and this issue are about the metadata correctness test. I was curious if you were also getting the issue mentioned here: #214 (comment). Thanks for the clarification! We are looking into the metadata correctness test failure. |
I have also logged with with WinUI. Do you understand what is going on here? The issue is fixed in one version, then regresses in the next!? It's happened twice already! It's really weird... |
@under3415. Sorry to hear that you are hitting this issue again. Looking at your post here it looks like WACK was failing when you updated to Microsoft.UI.XAML 2.6.0-prerelease.210315002. When this happened what version of Lottie were you on? If you keep Lottie on the last version that passed WACK(please let us know which one that is) are you able to identify which versions of Microsoft.UI.XAML 2.6.0-prerelease caused you to fail WACK? Does the issue repro for you with the Lottie Sample app when using Microsoft.UI.XAML 2.6.0-prerelease.210405001 and Microsoft.Toolkit.Uwp.UI.Lottie v7.0.2. If not do you have a simple app you could share with us that repros this issue with these versions of Lottie and Microsoft.UI.XAML? |
Lottie version does not seem to matter, the issue is fixed and broken in WinUI: 2.5.0-prerelease.201202003 OK I'm raising it here as well as in WinUI as I am not sure who needs to fix this, and why is it regressing. |
This issue only happens when you try to submit to Microsoft Store on a "Non-flighted submission". So to replicate the issue, create an app using lottie and winui and submit to store as "Non-flighted submission". |
Lottie version:7.0.2, Microsoft.UI.Xaml:2.5.0 |
Fixed by Microsoft.UI.XAML: microsoft/microsoft-ui-xaml#3780 |
Describe the bug
This problem occurs whenever I upgrade "Microsoft.Toolkit.Uwp.UI.Lottie" to version 6.0.0. Downgrading to version 5.1.1 is all right.
See the error for details:#2882,Just like what @dpaulino said.
Because that issue has been closed.
XAML:
Microsoft.Toolkit.Uwp.UI.Lottie 5.1.1 work.
Steps to Reproduce
Steps to reproduce the behavior:
Expected behavior
Screenshots
Environment
The text was updated successfully, but these errors were encountered: