Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Store App Certification Fails after upgrading Microsoft.UI.XAML to v2.5.0 #405

Closed
under3415 opened this issue Dec 7, 2020 · 21 comments

Comments

@under3415
Copy link

under3415 commented Dec 7, 2020

Hi
I am using Microsoft.Toolkit.Uwp.UI.Lottie v.6.1.0 and Microsoft.UI.Xaml.

After I updated Microsoft.UI.Xaml from 2.5.0-prerelease201202003 to the v.2.5.0 (release) the app got rejected from the store with the following errors. This was the only change to the app, was all good with pre-release UI.Xaml

FAILED
General metadata correctness

Error Found: The general metadata correctness test detected the following errors:
    Parameter value of method add_AnimatedVisualInvalidated of type Microsoft.Toolkit.Uwp.UI.Lottie.ILottieVisualSourceClass in file Microsoft.Toolkit.Uwp.UI.Lottie.winmd references the non-Windows Runtime type Microsoft.UI.Xaml.Controls.IDynamicAnimatedVisualSource. Windows Runtime types can reference only Windows Runtime types.
    The type Microsoft.UI.Xaml.Controls.IAnimatedVisual referenced by type Microsoft.Toolkit.Uwp.UI.Lottie.ILottieVisualSourceClass in file Microsoft.Toolkit.Uwp.UI.Lottie.winmd was not found. All types referenced in metadata files must be discoverable.

    Parameter value of method add_AnimatedVisualInvalidated of type Microsoft.Toolkit.Uwp.UI.Lottie.LottieVisualSource in file Microsoft.Toolkit.Uwp.UI.Lottie.winmd references the non-Windows Runtime type Microsoft.UI.Xaml.Controls.IDynamicAnimatedVisualSource. Windows Runtime types can reference only Windows Runtime types.
    The type Microsoft.UI.Xaml.Controls.IAnimatedVisual referenced by type Microsoft.Toolkit.Uwp.UI.Lottie.LottieVisualSource in file Microsoft.Toolkit.Uwp.UI.Lottie.winmd was not found. All types referenced in metadata files must be discoverable.
@under3415
Copy link
Author

Same thing after upgrading Lottie to to v.7.0.0-preview4

@nishitha-burman
Copy link
Collaborator

Hi @under3415,

Thank you for reaching out, we are investigating this issue.

@nishitha-burman
Copy link
Collaborator

nishitha-burman commented Dec 8, 2020

Hi @under3415,

Have you tried this: #214 (comment)?

@under3415
Copy link
Author

Forgot about that one, I'll try that, thanks! The issue was fixed in pre-release, but resurfaced in v2.5.0.
BTW I've also logged it here and they seem to know the root cause: microsoft/microsoft-ui-xaml#3298

@under3415
Copy link
Author

Hi @under3415,

Have you tried this: #214 (comment)?

Hi
Yep that worked! Thanks
D

@under3415 under3415 reopened this Dec 8, 2020
@under3415
Copy link
Author

Actually, the workaround didn't work. It was accepted for a "test flight", but not for a production release.
So below workaround did not work.
#214 (comment)

@nishitha-burman
Copy link
Collaborator

Hi @under3415,

We are investigating the issue.

@nishitha-burman
Copy link
Collaborator

Hi @under3415,

We are still investigating the issue, apologies for the wait. Are you able to use the pre-release version until there is a fix?

@under3415
Copy link
Author

Hi
Thanks for the update!

Yes, I am using Microsoft.Toolkit.Uwp.UI.Lottie 7.0.0-preview4 with Microsoft.UI.Xaml 2.5.0-prerelease.201202003 for now. That is working and being accepted by the store.

Regards

@under3415
Copy link
Author

I have installed the latest Microsoft.UI.Xaml v.2.6.0-prerelease210129001 and that works with Microsoft.Toolkit.Uwp.UI v7.0.0-preview4

@nishitha-burman
Copy link
Collaborator

@under3415 thank you for the update and glad it works! I will go ahead and close this issue. Please reopen this issue if other problems come up. Thank you!

@under3415
Copy link
Author

Hi
This is again an issue with the latest versions of UI XAML and Lottie:

  • Microsoft.UI.XAML 2.6.0-prerelease.210405001
  • Microsoft.Toolkit.Uwp.UI.Lottie v7.0.2

Error Found: The general metadata correctness test detected the following errors:

Parameter value of method add_AnimatedVisualInvalidated of type Microsoft.Toolkit.Uwp.UI.Lottie.ILottieVisualSourceClass in file Microsoft.Toolkit.Uwp.UI.Lottie.winmd references the non-Windows Runtime type Microsoft.UI.Xaml.Controls.IDynamicAnimatedVisualSource. Windows Runtime types can reference only Windows Runtime types.
The type Microsoft.UI.Xaml.Controls.IAnimatedVisual referenced by type Microsoft.Toolkit.Uwp.UI.Lottie.ILottieVisualSourceClass in file Microsoft.Toolkit.Uwp.UI.Lottie.winmd was not found. All types referenced in metadata files must be discoverable.
Parameter value of method add_AnimatedVisualInvalidated of type Microsoft.Toolkit.Uwp.UI.Lottie.LottieVisualSource in file Microsoft.Toolkit.Uwp.UI.Lottie.winmd references the non-Windows Runtime type Microsoft.UI.Xaml.Controls.IDynamicAnimatedVisualSource. Windows Runtime types can reference only Windows Runtime types.
The type Microsoft.UI.Xaml.Controls.IAnimatedVisual referenced by type Microsoft.Toolkit.Uwp.UI.Lottie.LottieVisualSource in file Microsoft.Toolkit.Uwp.UI.Lottie.winmd was not found. All types referenced in metadata files must be discoverable.

@under3415
Copy link
Author

@nishitha-burman can you please re-open this issue, I don't have permissions?

@nishitha-burman
Copy link
Collaborator

Hi @under3415,

Thank you for reaching out. We will take a look.

@under3415
Copy link
Author

Hi,
Another RTM release, another store rejection!

I have updated Microrsoft.UI.Xaml to 2.6.0 and my app got rejected by the store (in test flight). There were no other changes. Unfortunately, the store no longer gives any details, just says "failed certification". There is no report :-(

image

Cert App on PC does not detect any issues.

Help please!

@nishitha-burman
Copy link
Collaborator

Hi @under3415,

Thank you for reaching out! What version of Lottie-Windows are you using?

@under3415
Copy link
Author

Hi
7.0.3. Below are all the packages in my solution

image

@under3415
Copy link
Author

Note that this is also raised with Win.UI.
microsoft/microsoft-ui-xaml#3780

@nishitha-burman
Copy link
Collaborator

I see, thank you. We are looking into this.

@nishitha-burman
Copy link
Collaborator

@under3415 it might also be related to this issue we are investigating: microsoft/microsoft-ui-xaml#5298

@nishitha-burman
Copy link
Collaborator

microsoft/microsoft-ui-xaml#5298 is tracking the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants