Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Changes to File Icon Type setting not reflected in UI immediately #1765

Closed
austincondiff opened this issue Jun 20, 2024 · 2 comments
Closed

🐞 Changes to File Icon Type setting not reflected in UI immediately #1765

austincondiff opened this issue Jun 20, 2024 · 2 comments
Assignees
@hkarmoush
Labels
bug Something isn't working navigator settings triage needed UI This is UI related

Comments

@austincondiff
Copy link
Collaborator

austincondiff commented Jun 20, 2024 •
edited
Loading

Description

When the user changes the file icon style setting, updates to the UI are not reflected immediately. Instead the user is required to change navigators to something else and then go back to the project navigator to see any UI changes.

To Reproduce

  1. Open settings
  2. Change "File Icon Type" setting
  3. Notice there are no changes to the icon color
  4. Go to another navigator
  5. Return to the project navigator
  6. Notice the icon colors changed

Expected Behavior

Icon colors should change as a direct result of your selection of the File Icon Type settings immediately without reinitializing the project navigator view.

Screenshots

Screen.Recording.2024-06-20.at.11.05.40.AM.mp4
@austincondiff austincondiff added the bug Something isn't working label Jun 20, 2024
@austincondiff austincondiff changed the title 🐞 Changes to File Icon Type setting not seen in UI immediately 🐞 Changes to File Icon Type setting not reflected in UI immediately Jun 20, 2024
hkarmoush added a commit to hkarmoush/CodeEdit that referenced this issue Jun 22, 2024
@hkarmoush
File Icon Type setting reflects immediately CodeEditApp#1765
41b80d4
@hkarmoush hkarmoush mentioned this issue Jun 22, 2024
Merged
6 tasks
@hkarmoush
Copy link
Contributor

Feel free to assign issue to me if there are any comments on my fix

tom-ludwig added a commit that referenced this issue Jun 23, 2024
@hkarmoush @tom-ludwig
File Icon Type setting reflects immediately #1765 (#1773)
f683b6b 
* File Icon Type setting reflects immediately #1765
---------

Co-authored-by: Tom Ludwig <[email protected]>
@tom-ludwig
Copy link
Member

It appears that issue #1765 has been resolved with PR #1733. As a reminder, please include - closes #0000 in PR descriptions to automatically link and close related issues.

@github-project-automation github-project-automation bot moved this from 🆕 New to 🏁 Complete in CodeEdit Project Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hkarmoush hkarmoush

Labels
bug Something isn't working navigator settings triage needed UI This is UI related
Projects
CodeEdit Project
Status: 🏁 Complete
Milestone
No milestone
Development

No branches or pull requests
3 participants
@austincondiff @hkarmoush @tom-ludwig