Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer settings menu #1733

Merged
merged 11 commits into from
May 26, 2024
Merged

Developer settings menu #1733

merged 11 commits into from
May 26, 2024

Conversation

FastestMolasses
Copy link
Member

@FastestMolasses FastestMolasses commented May 23, 2024

Description

This PR adds a settings menu for developers to add LSP binaries. Currently, this settings menu is intended to be removed before 1.0 releases, unless we would like a generalized 'dev' settings menu, for CodeEdit developers. This PR is needed before we can merge the LSP backend into the main branch.

Related Issues

Closes #1732

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screenshot 2024-05-23 at 5 17 56 AM

@austincondiff
Copy link
Collaborator

austincondiff commented May 23, 2024

You could rename this settings pane to be developer to be more generic and then add a section title “LSP binaries” above the table. Maybe this settings pane appears when you hit a certain key five times or something.

Copy link
Member

@tom-ludwig tom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really happy to see us moving in the right direction!

CodeEdit/Features/CodeEditUI/Views/KeyValueTable.swift Outdated Show resolved Hide resolved
CodeEdit/Features/CodeEditUI/Views/KeyValueTable.swift Outdated Show resolved Hide resolved
CodeEdit/Features/Settings/SettingsView.swift Outdated Show resolved Hide resolved
CodeEdit/Features/CodeEditUI/Views/KeyValueTable.swift Outdated Show resolved Hide resolved
@FastestMolasses
Copy link
Member Author

Screenshot 2024-05-23 at 10 29 00 AM Screenshot 2024-05-23 at 10 29 09 AM

Here's what it currently looks like

@FastestMolasses
Copy link
Member Author

Maybe this settings pane appears when you hit a certain key five times or something.

What about using F12 to toggle the dev menu? Similar to the dev menu in browsers.

@FastestMolasses FastestMolasses self-assigned this May 23, 2024
@FastestMolasses FastestMolasses added UI This is UI related settings debug labels May 23, 2024
@austincondiff
Copy link
Collaborator

You might wrap the two inputs in a Form with a .formStyle(.grouped) modifier.

@FastestMolasses
Copy link
Member Author

FastestMolasses commented May 24, 2024

Here is the new modal with the .formStyle(.grouped) modifier:

Screenshot 2024-05-23 at 11 26 40 PM

Here is the functionality of showing / hiding the developer menu with F12:

Screen.Recording.2024-05-23.at.11.28.08.PM.mov

@austincondiff
Copy link
Collaborator

austincondiff commented May 24, 2024

It should look like this…
image
There should also be a delete button.
You can refer to SourceControlNavigatorNewBranchView.

@FastestMolasses
Copy link
Member Author

FastestMolasses commented May 25, 2024

Updated the style

Screenshot 2024-05-25 at 12 10 40 AM

Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for getting that form design right!

Copy link
Member

@tom-ludwig tom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FastestMolasses FastestMolasses merged commit f2caddf into main May 26, 2024
2 checks passed
@FastestMolasses FastestMolasses deleted the lsp-menu branch May 26, 2024 10:29
@thecoolwinter thecoolwinter added the enhancement New feature or request label Jul 19, 2024
@thecoolwinter thecoolwinter added the language server Issues or Pull Requests related to language servers. label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug enhancement New feature or request language server Issues or Pull Requests related to language servers. settings UI This is UI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Settings Developer Menu
4 participants