-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Developer settings menu #1733
Developer settings menu #1733
Conversation
You could rename this settings pane to be developer to be more generic and then add a section title “LSP binaries” above the table. Maybe this settings pane appears when you hit a certain key five times or something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really happy to see us moving in the right direction!
CodeEdit/Features/Settings/Pages/LSPSettings/LSPSettingsView.swift
Outdated
Show resolved
Hide resolved
What about using F12 to toggle the dev menu? Similar to the dev menu in browsers. |
You might wrap the two inputs in a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for getting that form design right!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR adds a settings menu for developers to add LSP binaries. Currently, this settings menu is intended to be removed before 1.0 releases, unless we would like a generalized 'dev' settings menu, for CodeEdit developers. This PR is needed before we can merge the LSP backend into the main branch.
Related Issues
Closes #1732
Checklist
Screenshots