Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Icon Type setting reflects immediately #1765 #1773

Conversation

hkarmoush
Copy link
Contributor

@hkarmoush hkarmoush commented Jun 22, 2024

Description

File icons were not reflected immediately when changed from the settings.

on willSet for iconColor I only reload the outlineView

Related Issues

#1765

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

austincondiff
austincondiff previously approved these changes Jun 23, 2024
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep up the good work 👍

tom-ludwig
tom-ludwig previously approved these changes Jun 23, 2024
@tom-ludwig tom-ludwig dismissed stale reviews from FastestMolasses, austincondiff, and themself via 25d8d76 June 23, 2024 08:33
@tom-ludwig tom-ludwig enabled auto-merge (squash) June 23, 2024 08:35
@tom-ludwig tom-ludwig merged commit f683b6b into CodeEditApp:main Jun 23, 2024
2 checks passed
@thecoolwinter thecoolwinter added the bug Something isn't working label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants