Bring back **garbage** dns tests

[arthurpassos]

Changelog category (leave one):

• Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Three tests were failing / flaky:

1. test_host_regexp_multiple_ptr_records
2. test_host_regexp_multiple_ptr_records_concurrent
3. test_reverse_dns_query

Hard coding coredns version to 1.9.3 (latest version of coredns when these tests were introduced) fixed 1 and 2. The latter was failing because we relied on google dns, but that can fail sometimes. To fix this, I simply setup a DNS server for this test as well. It does not rely on 3rd party stuff anymore.

Closes #51471

Documentation entry for user-facing changes

• Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

[arthurpassos]

@tavplubix @alexey-milovidov

[clickhouse-ci]

This is an automatic comment. The PR descriptions does not match the template.

Please, edit it accordingly.

The error is: More than one changelog category specified: 'Build/Testing/Packaging Improvement', 'Three tests were failing / flaky:'

[robot-clickhouse-ci-2]

This is an automated comment for commit 1c3f926 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	🟢 success
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	🟡 pending
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	🟢 success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	🟢 success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	🟢 success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	🟢 success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	🟢 success
Install packages	Checks that the built packages are installable in a clear environment	🟢 success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	🟢 success
Mergeable Check	Checks if all other necessary checks are successful	🟢 success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	🔴 failure
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	🟢 success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	🟢 success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	🟢 success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🟢 success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🟢 success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	🟢 success
Style Check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	🟢 success
Unit tests	Runs the unit tests for different release types	🟢 success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	🟢 success

[arthurpassos]

@tavplubix @alexey-milovidov I assume the failures are from unrelated garbage?

[alexey-milovidov]

@arthurpassos Sure. There was another "garbage" session_log: #51760

I've reverted it in a blink: #53255

But as long as we have some unrelated garbage, pull requests cannot be merged.
It's a requirement - make it 100% clean before merging.

[alexey-milovidov]

Also, @tavplubix pointed out that we will remove test_tlsv1_3 and test_zookeeper_config.

[qoega]

There is still an issue with this tests
https://s3.amazonaws.com/clickhouse-test-reports/66867/34c8351bce754740a18388dd623309dfb6030bb0/integration_tests__asan__old_analyzer__[1_6].html

[alexey-milovidov]

@arthurpassos

E               compose.cli.verbose_proxy.proxy_callable: docker inspect_network <- ('roottesthostregexpmultipleptrrecords_default')
E               compose.network.ensure: Creating network "roottesthostregexpmultipleptrrecords_default" with driver "bridge"
E               compose.cli.verbose_proxy.proxy_callable: docker create_network <- (name='roottesthostregexpmultipleptrrecords_default', driver='bridge', options=None, ipam={'Driver': 'default', 'Config': [{'Subnet': '10.5.0.0/12', 'IPRange': None, 'Gateway': '10.5.1.1', 'AuxiliaryAddresses': None}, {'Subnet': '2001:3984:3989::/64', 'IPRange': None, 'Gateway': '2001:3984:3989::1', 'AuxiliaryAddresses': None}]}, internal=None, enable_ipv6=True, labels={'com.docker.compose.project': 'roottesthostregexpmultipleptrrecords', 'com.docker.compose.network': 'default', 'com.docker.compose.version': '1.29.2'}, attachable=True, check_duplicate=True)
E               compose.cli.errors.log_api_error: invalid network config:
E               invalid subnet 10.5.0.0/12: it should be 10.0.0.0/12

[arthurpassos]

@arthurpassos

E               compose.cli.verbose_proxy.proxy_callable: docker inspect_network <- ('roottesthostregexpmultipleptrrecords_default')
E               compose.network.ensure: Creating network "roottesthostregexpmultipleptrrecords_default" with driver "bridge"
E               compose.cli.verbose_proxy.proxy_callable: docker create_network <- (name='roottesthostregexpmultipleptrrecords_default', driver='bridge', options=None, ipam={'Driver': 'default', 'Config': [{'Subnet': '10.5.0.0/12', 'IPRange': None, 'Gateway': '10.5.1.1', 'AuxiliaryAddresses': None}, {'Subnet': '2001:3984:3989::/64', 'IPRange': None, 'Gateway': '2001:3984:3989::1', 'AuxiliaryAddresses': None}]}, internal=None, enable_ipv6=True, labels={'com.docker.compose.project': 'roottesthostregexpmultipleptrrecords', 'com.docker.compose.network': 'default', 'com.docker.compose.version': '1.29.2'}, attachable=True, check_duplicate=True)
E               compose.cli.errors.log_api_error: invalid network config:
E               invalid subnet 10.5.0.0/12: it should be 10.0.0.0/12

@qoega @alexey-milovidov

This error does not seem related to the test, but rather to the docker set up. It fails because of invalid subnet during startup of docker image, but this is not set by test code. See docker-compose-file and coredns setup.

I tried searching for this error message on google and there are not a lot of good results. This usually happens when user tries to hard-code the subnet, but it is not the case unless I am missing something.

Plus, this is the only time this test has failed aside from the release PR you guys have open. I think it is an emphemeral failure due to some environment issue that is out of my control.

I suggest we leave it like this. If it happens again, please don't hesitate to ping me. What do you think?

[alexey-milovidov]

Thank you! However, I really dislike ephemeral failures.

[qoega]

Actually it is not ephemeral, but is triggered by docker update, so we will need to fix tests that use dns to upgrade docker

[arthurpassos]

Actually it is not ephemeral, but is triggered by docker update, so we will need to fix tests that use dns to upgrade docker

I don't quite follow. Are you saying that whenever you try to update the docker version, coredns related tests break? And only coredns related?

[qoega]

Yes. Here is PR with updated docker version
#66867

[arthurpassos]

Yes. Here is PR with updated docker version #66867

Hm. We are using a pinned & old version of coredns, maybe upgrading it could do the trick? In any case, the current code does not work with latest version of coredns, so it'll have to be updated. Can you unpin the docker version on the PR and see if it fixes the subnet issue? If it does, I can spend some time on Monday trying to update the test code itself.