23.3.19 Pre-release PR for 23.3.19.33.altinitystable #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add comment and rename github robot token add clickhouse instance password parameter use Altinity's s3 bucket Use altinityinfra dockerhub images and minor adjustments (#135) Allow CI to be triggered on PR Proper error reporting during docker pull and lowercase version name allow `altinitystable` git tags Download specific MinIO version instead of latest - same as upstream master remove stale chmod More stable CI/CD builds: - Rebuilding all docker images - Reduced number of docker images - Rerunning functional tests even if those were already executed in previous run Added missing dependencies for stateful tests Re-generating _pb2 files on each test run Changed hardcoded docker images name prefixes from `clickhouse/` to `altinityinfra/` Pushing images as :latest too to avoid some test failures reverted back to use clickhouse/jdbc-bridge Fixed how version is generated: taking into account VERSION_TWEAK and VERSION_FLAVOUR Pushing checks events data to "gh-data" instead of "default" Using secrets for managing AWS access Fixed tag checking code to allow altinitystable version suffix Bumped Go version to get some CVE fixes Do not install clickhouse-diagnostics due to numerous CVEs in go runtime Removed unneeded docker images from list: codebrowser, sqlancer-test, keeper-jespen, keeper-jepsen-test, testflows-runner, fuzzer Using ccache instead of sccache Fixed ClickHouseVersion.get_version_from_string for some cases, fixed getting version flavour
Fix key condition on duplicate primary keys
…sary-sets Do not build sets for skip indexes if they are not used
23.3 Fix of DockerServerImages
…uild_skip_indices_if_not_used 23.3 backport of ClickHouse#48299 Do not build skip indices if not used
…condition_crash 23.3 backport of ClickHouse#48838 Fix crash with key condition on duplicate primary keys
Uploading src tgz and regression improvements
SignRelease cherrypick
23.3 port of #269 source upload
Changed order of jobs to make SignRelease start earlier than tests, and tests start after SignRelease
23.3 Port of #266 Signing binaries
…stomizations/23.3.5
…stomizations/23.3.8
…s_coredns_version 23.3 Backport of ClickHouse#53286 - Bring back **garbage** dns tests
…ldap-role-update Fix deadlock in LDAP assigned role update
…gration-test Fix flaky LDAP integration tests
Fixed merge conflict from rebasing
23.3 CI/CD: Fix SignRelease job
…D_incorrect_free_space_accounting 23.3 Backport of ClickHouse#56030 - Fix incorrect free space accounting for `least_used` JBOD policy - take 2
…ess_test_storage_shutdown_in_mergetreededuplicationlog 23.3 Backport of ClickHouse#52623 - Fix stress test: check if storage shutdown before we operate `MergeTreeDeduplicationLog`
…y::test_role_mapping
…ger_leak 23.3 Backport of ClickHouse#58831- Fix logger leak
Update of assigned roles (`GrantedRoles`) on `User` instance that occurs inside `LDAPAccessStorage` doesn't bubble up to `AccessStorate` and not broadcasted as an event to `AccessChangesNotifier` event handlers. Thus `AccessControl` that is held by `Context` never receives an event and is never updated, holding old instance of `User` with previous set of roles. `AccessControl` instances are cached for 600 seconds, so waiting for 600 + 10 seconds between sessions ensures that when user is logged in again, new `AccessControl` instance is created, and proper (updated `User`, with updated `GrantedRoles`) is created. This issue seems to be already fixed in upstream/master, but for now we are not going to backport it, just fix the test.
…P_deadlock_role_update 23.3 Backport of ClickHouse#55119 - Fix deadlock in LDAP assigned role update - take 2
|
This is an automated comment for commit ceabecc with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
23.3.19 CI/CD: Enable Santizers and Additional Testing
Enmk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes compared to upstream's v23.3.19.32-lts
Bug fixes
FINALproduces invalid read ranges in a rare case ClickHouse/ClickHouse#54934 by @nickitat via 23.3 Backport of #54934 FixFINALproduces invalid read ranges in a rare case #313)ratio_of_defaults_for_sparse_serializationback to1.0and restarting the server. (Fix reading from sparse columns after restart ClickHouse/ClickHouse#49660 by @CurtizJ via 23.3 Backport of #49660 - fix sparse columns reload #314)least_usedJBOD policy - take 2 #365)MergeTreeDeduplicationLog#366)Performance improvement
Improvement
Build/Testing/Packaging Improvement