Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23.3 CI/CD: Fix SignRelease job #368

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

Enmk
Copy link
Member

@Enmk Enmk commented Feb 8, 2024

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

sign_release.py using Path instead of str, as required by s3_helper.py.

Fixes https://github.com/Altinity/ClickHouse/actions/runs/7826936815/job/21356218878:

Traceback (most recent call last):
  File "/home/ubuntu/_work/ClickHouse/ClickHouse/tests/ci/sign_release.py", line 94, in <module>
    main()
  File "/home/ubuntu/_work/ClickHouse/ClickHouse/tests/ci/sign_release.py", line 72, in main
    s3_helper.upload_build_file_to_s3(signed_file_path, s3_path)
  File "/home/ubuntu/_work/ClickHouse/ClickHouse/tests/ci/s3_helper.py", line 126, in upload_build_file_to_s3
    return self._upload_file_to_s3(S3_BUILDS_BUCKET, file_path, s3_path)
  File "/home/ubuntu/_work/ClickHouse/ClickHouse/tests/ci/s3_helper.py", line 60, in _upload_file_to_s3
    if file_path.stat().st_size < 64 * 1024 * 1024:
AttributeError: 'str' object has no attribute 'stat'

@Enmk Enmk changed the title Attempt to fix SignRelease job 23.3 CI/CD Fix SignRelease job Feb 8, 2024
@Enmk Enmk changed the title 23.3 CI/CD Fix SignRelease job 23.3 CI/CD: Fix SignRelease job Feb 8, 2024
@altinity-robot
Copy link
Collaborator

altinity-robot commented Feb 8, 2024

This is an automated comment for commit f2e7646 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
Ready for releaseThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@Enmk Enmk merged commit 643f2c9 into customizations/23.3.19 Feb 9, 2024
133 of 141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants