22.8.15 Backport of #53286 - Bring back dns tests #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Three tests were failing / flaky:
test_host_regexp_multiple_ptr_records
test_host_regexp_multiple_ptr_records_concurrent
test_reverse_dns_query
Hard coding coredns version to 1.9.3 (latest version of coredns when these tests were introduced) fixed 1 and 2. The latter was failing because we relied on google dns, but that can fail sometimes. To fix this, I simply setup a DNS server for this test as well. It does not rely on 3rd party stuff anymore.
Backport ClickHouse#53286
Documentation entry for user-facing changes