Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only fill items as much as parent containers allow #60043

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

mqrause
Copy link
Contributor

@mqrause mqrause commented Aug 9, 2022

Summary

Bugfixes "Only fill items as much as parent containers allow"

Purpose of change

Fixes #56183
Fixes #55647
Fixes #50843

Describe the solution

  • use item_location for container in Character::pour_into
  • check parents for amount of charges to transfer

Describe alternatives you've considered

Testing

Wear Jeans, spawn a condom and a few water bottles to fill the pockets (I also had some other stuff in it that came with the scenario). Unload water bottles into condom. Could only pour 1 charge into the condom. Unload condom back into water bottle. Examine water tile and pour water into the condom. Again could only pour 1 charge into it.

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Aug 9, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 9, 2022
@dseguin dseguin merged commit 1b57cba into CleverRaven:master Aug 10, 2022
@mqrause mqrause deleted the nested_container_fill_fix branch August 10, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
2 participants