Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when filling condom that is stored in small container when larger container is available #56183

Closed
BoatNectar opened this issue Mar 18, 2022 · 1 comment · Fixed by #60043
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` Items: Containers Things that hold other things (S2 - Confirmed) Bug that's been confirmed to exist (S3 - Duplicate) Bug that is duplicate of another one

Comments

@BoatNectar
Copy link
Contributor

Describe the bug

Whenever I go to fill a condom stored in a small container or pocket (eg pants pocket) while carrying a larger container (eg empty duffel bag) I get an error on every turn that the condom remains in an unfit container or pocket.

Steps to reproduce

  1. Get a container or article of clothing with a maximum volume smaller than a filled condom (filled condom is around 5L) but larger than an unused condom
  2. Get 1 (or more) condom(s)
  3. Get a bag capable of holding your full condoms making sure the unused condoms are kept in the first container
  4. Interact with a water source such as a pond or puddle and fill your condom(s) with water an error will occur and will reoccur every turn

Expected behavior

Ideally the game would move the condom to an appropriate container if available and prompt the player when trying to fill a condom they don't have space to carry and give them the option to drop the filled condom or cancel filling.

Screenshots

image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.22000.556 (21H2)
  • Game Version: 714f560 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Stats Through Kills [stats_through_kills],
    Stats Through Skills [StatsThroughSkills]
    ]

Additional context

DEBUG : volume exceeds capacity (5610ml > 1600ml)

FUNCTION : relative_encumbrance
FILE : D:\a\Cataclysm-DDA\Cataclysm-DDA\src\item_contents.cpp
LINE : 1872
VERSION : 714f560

@NetSysFire
Copy link
Member

Can reproduce, but it may be a semi-duplicate of #47046

In this case I spawned a dress shirt, put the condom in its pocket, wore a duffel bag I spawned and filled the condom with water, then got the errors.

@NetSysFire NetSysFire added <Bug> This needs to be fixed (S3 - Duplicate) Bug that is duplicate of another one (S2 - Confirmed) Bug that's been confirmed to exist [C++] Changes (can be) made in C++. Previously named `Code` Items: Containers Things that hold other things 0.G suggested release blocker labels Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` Items: Containers Things that hold other things (S2 - Confirmed) Bug that's been confirmed to exist (S3 - Duplicate) Bug that is duplicate of another one
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants