Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not enough space in (military rucksack?) pocket debug error after using heatpack #47046

Closed
PaulBlay opened this issue Jan 26, 2021 · 3 comments
Closed
Labels
<Bug> This needs to be fixed Items: Containers Things that hold other things

Comments

@PaulBlay
Copy link

PaulBlay commented Jan 26, 2021

Describe the bug

While heating up an entree from an MRE with a heat pack I got a debug error. It looks like more is being placed in the backpack that can actually fit there but it only notices when you try to use something?

DEBUG : volume exceeds capacity (3502ml > 3400ml)

FUNCTION : float item_contents::relative_encumbrance() const
FILE : src/item_contents.cpp
LINE : 1500

Steps To Reproduce

You can reliably reproduce the bug from the save below:

Narnia.zip

  1. Load save. Note that you get the following error

DEBUG : error: item heatpack_used cannot fit into pocket while loading: not enough space

FUNCTION : void item_contents::combine(const item_contents&, bool)
FILE : src/item_contents.cpp
LINE : 335

Which looks like the same problem as #46852

  1. Debug spawn in a heat pack
  2. (a)ctivate heat pack and use it to heat something.
  3. Observe error message

DEBUG : volume exceeds capacity (3502ml > 3400ml)

FUNCTION : float item_contents::relative_encumbrance() const
FILE : src/item_contents.cpp
LINE : 1500

Expected behavior

Not to have debug errors while using heat pack. There should probably be a "Heat pack is too heavy to pick up" shown when you try to find it in the list to (a)ctivate it (if it is too heavy). I'm not sure exactly what is going on.

Screenshots

Versions and configuration

  • OS: Windows x64 8.1
  • Game Version: 0.E-9155-g1319073-dirty [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Bionic Professions [package_bionic_professions],
    No Fungal Monsters [No_Fungi],
    Stats Through Skills [StatsThroughSkills],
    SpeedyDex [speedydex],
    Stats Through Kills [stats_through_kills]
    ]

Additional context

The heatpack is probably a little broken - you can use one to reheat an entire 20L of frozen water in a steel jerry can.

@PaulBlay PaulBlay changed the title Debug errors after using heatpack Not enough space in (military rucksack?) pocket debug error after using heatpack Jan 26, 2021
@anothersimulacrum anothersimulacrum added <Bug> This needs to be fixed Items: Containers Things that hold other things labels Jan 26, 2021
@PaulBlay
Copy link
Author

Both this and the RC Car bug involve objects that change into other objects (heat pack -> used heat pack, RC Car -> RC Car (on) ). Maybe something is getting lost (or added) in the transformation?

@BrettDong
Copy link
Member

Seems should add item_contents::overflow somewhere to enforce item pocket volume constraints.

@Night-Pryanik
Copy link
Contributor

Can't confirm on 0.F-12701.

@Night-Pryanik Night-Pryanik closed this as not planned Won't fix, can't repro, duplicate, stale Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Items: Containers Things that hold other things
Projects
None yet
Development

No branches or pull requests

4 participants