Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size changing containers in containers can lead to error or invalid pockets #50843

Closed
StStep opened this issue Aug 17, 2021 · 2 comments · Fixed by #60043
Closed

Size changing containers in containers can lead to error or invalid pockets #50843

StStep opened this issue Aug 17, 2021 · 2 comments · Fixed by #60043
Labels
<Bug> This needs to be fixed Items: Containers Things that hold other things (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@StStep
Copy link
Contributor

StStep commented Aug 17, 2021

Describe the bug

Basically what was happening with #50512 but with resizing containers. I saw this when filling a condom in my inventory with water, but it probably happens with other containers that can change size. It sometimes throws an error or will just let you have a pocket with too much in it.

The error seems to occur when the newly filled condom is too big for all the combined pockets in the container. If you have spare room in other pockets it, it doesn't error out but drops on a future inventory update. Before the update occurs you can see the pocket is overfilled. So it easiest to create the error using an item with only a single pocket.

Steps To Reproduce

  1. Make a player with a condom and another container and a liquid to fill the condom with
  2. Place the condom in the container and place enough other things to fill that container
  3. Pour a liquid into the condom
  4. Either get an error or check pocket the condom is in to see it's oversized.

Expected behavior

I expect to be prevented from filling the condom or for the condom to be forced to be removed in the case of the error.
too-much-milk

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 2009
  • Game Version: 0.F-1657-g0a85313753 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Bionic Professions [package_bionic_professions]
    ]

Additional context

No response

@actual-nh actual-nh added (S1 - Need confirmation) Report waiting on confirmation of reproducibility Items: Containers Things that hold other things labels Aug 17, 2021
@hexagonrecursion
Copy link
Contributor

Confirmed

  • OS: Linux
    • OS Version: LSB Version: :core-4.1-amd64:core-4.1-noarch; Distributor ID: Fedora; Description: Fedora release 33 (Thirty Three); Release: 33; Codename: ThirtyThree;
  • Game Version: 17b9ea1 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Bionic Professions [package_bionic_professions]
    ]

@ZhilkinSerg ZhilkinSerg added (S2 - Confirmed) Bug that's been confirmed to exist <Bug> This needs to be fixed and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Aug 17, 2021
@Xpyder
Copy link
Contributor

Xpyder commented Aug 18, 2021

Not sure if related but there's also a bug where sometimes I can't insert into a stored container unless I wield it first, even if it goes back into the same pocket afterwards so there may be a bug in how it assesses available space for layered containers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Items: Containers Things that hold other things (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants