-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new martial art: Bayonet Drill #49445
Conversation
Toss the changed files in the linter for fix formatting issues. |
data/json/martialarts.json
Outdated
"learn_difficulty": 5, | ||
"arm_block": 0, | ||
"primary_skill": "stabbing", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you going to add a MA manual for these to matter in this PR, or a second one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was considering use existing manual_stabbing
as a manual book. But I'm not decided yet.
Can I leave it blank?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just replicate the knife manual but with the new MA? I'd like to add this would be a good one for learning from NPCs.
CC @Hymore246 |
I've considered that when I was making OnPause/OnMove Buff. As for "Attack Position" part. |
Love seeing more practical martial arts, big props. |
improve combat combo
data/json/martialarts.json
Outdated
"type": "martial_art", | ||
"id": "style_bayonet_drill", | ||
"name": { "str": "Bayonet Drill" }, | ||
"description": "Bayonet charge was a common tactic used during the early modern wars. It focuses on move one's body to keep or regain his own balance, and exploits weaknesses in his opponent's balance.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"description": "Bayonet charge was a common tactic used during the early modern wars. It focuses on move one's body to keep or regain his own balance, and exploits weaknesses in his opponent's balance.", | |
"description": "Bayonet charge was a common tactic used during the early modern wars. It focuses on move one's body to keep or regain his own balance, and exploits weaknesses in his opponent's balance.", |
data/json/martialarts.json
Outdated
{ | ||
"id": "buff_bayonet_drill_onpause", | ||
"name": "Attack position", | ||
"description": "You hold your rifle diagonally across your body at a sufficient distance from the body to add balance and protect you from enemy blows.\n\nBlocked damage reduced by 50% of Perception, +1 Block attempts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"description": "You hold your rifle diagonally across your body at a sufficient distance from the body to add balance and protect you from enemy blows.\n\nBlocked damage reduced by 50% of Perception, +1 Block attempts", | |
"description": "You hold your rifle diagonally across your body at a sufficient distance from the body to add balance and protect you from enemy blows.\n\nBlocked damage reduced by 50% of Perception, +1 Block attempts.", |
Shame that I did not put in M1, Mosin Nagant and Springfield at the beginning.
I'll give some feedback on the style. At first, I thought that guns shouldn't be able to block. After all, they are designed to shoot not stop attacks. But after some research, I found that historically, rifles have been used to block attacks. This makes sense in real life too. I wouldn't try to shield myself with a pistol but a large gun? I would try to put it between myself and my attacker if I had to. To answer your question about why you can't get the guns to block, it is because an weapon must have either WBLOCK_1, WBLOCK_2, or WBLOCK_3 as a weapon technique to be able to block. I would recommend as part of this PR that you add WBLOCK_1 to all the rifles in the game to allow them to block attacks. Vs Taekwando, Krav Maga, and Soujutsu We need to make sure that Bayonet Drill has a place functionally in the game compared to other styles. It competes with Taekwando and Krav Maga since these styles can be used with rifles and Soujutsu since having a bayonet mod on a gun allows you to perform reach attacks. Weapon styles are tricky to balance and ones that use firearms are even harder. Guns are one of the strongest weapons in the CDDA so we need to keep that in mind when balancing the style. Lets look at the other styles first:
So where does this leave Bayonet Drill? Well, I think the best niche for the style is to a more offensive style that rewards you for attacking mid-ranged opponents. Ideally, I see the style being used when enemies that have already been damaged several times by gunfire. You then rush an enemy and quickly finish them off before turning your attention elsewhere. Unlike the other styles, Bayonet Drill should have damage boosting buffs and techniques with the catch that they only affect Stab damage. The trick here is that we want players to want to put a bayonet on the rifle but we have no way to check for it existing on the backend. So we can slightly reduce the effectiveness of the style by limiting the bonus damage to a type that does not exist on rifles UNLESS you add a bayonet. As mentioned before, we want to be able to be able to block so adding a block counter and some support for it will round out the style. Comments on Existing Style
Example Style
Breakdown:
I hope this help. Let me know if you have any questions or comments. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
Hey @Aerotinge. What's going on with this? Still working on it? :) |
Due to the removal of counters (#51949), the style will probably need an additional tweak to function without a block counter. But that is up to the author to decide what the revised style will look like. |
Thanks @Hymore246 for revision first, and sorry for replying so late. Haven't played CDDA for months. Before Styles, I'd talking the core idea behind bayonet (of course my own opinion)
After abstracting the above situation and these canonical actions, I got a martial art that should be
Now Styles (Finally!), I don't like any static buff since whole bayonet is based on initial actions. And one action after one, there's no static things shared in both movement and stillness.
And your revisions,
breakpoint: Nowadays bayonet drill do emphasize stabbing part and less focus on butt strike part, due to pistol-style grips are so common in modern self-loading rifles such as the AR-15 and M16, making butt strikes hard to practice.
So far it's still in a bad shape since I can not make blocking working, and I probably not playing CDDA in the 0.F lifespan. |
I am closing this as stale for now. If someone would like to pick this project up, or if the original poster returns, please either duplicate it or reopen it. |
Summary
Content "Add new martial art: Bayonet Drill"
Purpose of change
I need a military skill in real army, not mystery kung fu or far-away Israel CQB.
Describe the solution
Add a standard US-style bayonet drill combat skill as a martial art.
Bayonet Drill Buffs
Bayonet Drill Techniques
Acceptable weapons
Rifles, but
Problems and issues
"arm_block": 0
but not working well.What left behind
There's still many firearms that is not able to use this martial art. Theorically any rifle with bayonet mount set can use this martial art.But they're too many...and even shotgun could. I just need some time to find out all of them.
Describe alternatives you've considered
Overall, I try to make its dps close to
spear_knife
.The base move per attack of a rifle with bayonet is pretty large(~200) make it hard to be a good martial art
But in early game, it's a decent melee weapon when you're out of ammo.
Testing
Put the files in a5c3b7f and it works as expected.
Additional context
References:
https://www.survivalschool.us/wp-content/uploads/2018/06/FM-21-150-Combatives-1992.pdf
https://wartimecanada.ca/sites/default/files/documents/Bayonet%20training%201916.pdf
My own military service experience