-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
standardize zines (books, not ammo) #40274
Conversation
update long items length and their volume/weight
I resolved conflicts between this and #37377 - just fyi |
create "abstract": "book_nonf_manual_tpl"
book_nonf_binder_cook_tpl
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
I keep putting off reviewing this, sorry about that.
|
Summary
SUMMARY: Content "abstract for magazines w appropriate dimensions"
Purpose of change
By making an abstract of magazines we simplify the json and the ease with which we can apply universal updates to magazines.
Magazines now all have the same height and width. They also all have longest side as needed by #40186
Describe the solution
classes/book.jsonabstract.jsonDescribe alternatives you've considered
While there is a standard magazine size, not every magazine conforms to it perfectly. There probably are 3 or 4 most common formats, and then ones unique to a given periodical. Those can be accounted but adding the custom values to the individual magazines or, better yet, creating alternative zine dimension abstracts in classes/book.json and then associating the zines with those formats.
Should all softcover books have one or both of these flags?
"flags": [ "TINDER", "FLAMMABLE" ],
Many of the books had thematic coloring - a book about wine will be red and the milk cookbook was white - I changed those to conform to the color key in the doc. Hopefully that was the right thing to do.
Additional context
I have a much more involved PR #37377 that provides a structure of "cascading" abstracts for books, along with cascading SUS item groups. It has now been approved; some of the changes associated with this PR are resolving conflicts to conform with the other.