m Update JSON_INHERITANCE.md #42419
Merged
m Update JSON_INHERITANCE.md #42419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
added
the
<Documentation>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
add a guidelines section to json inheritance doc advising contributors not to over use copy-from
Describe alternatives you've considered
Let @kevingranade write up guidelines for data inheritance. I am attempting to save him the trouble or at least put up a draft until he gets the opportunity.
Additional context
I got these guidelines via #40274 (ie., Don't do what I did and create a complicated cascade of inheritance 7 levels deep.)