-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spaces Removal #39485
Spaces Removal #39485
Conversation
@@ -31,5 +31,4 @@ In the case of "how is a spell part of a class?" the spell's characteristics det | |||
- Biomancer: Flesh mage. Manipulating the caster's flesh is easier but higher tier spells can manipulate others' flesh. Features Acid. | |||
- Druid: Plant mage. Communes with nature. The typical "druid" of old is usually a combination of this class and Earthshaper. Has a slight secondary affinity with water. | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't you need the double space in markdown to get a line break?
Generally corrections of this sort which do not actually impact content are reserved for when there are actual content changes, so that Conversely, this PR produces an absurd amount of noise for tracking actual content history for no obvious reason. Is this actually in the service of anything? |
I'm in favour of cleaning up our style, but only if this style becomes enforced by the CI. For example, I'd be happy to see a PR which added flake8 verification of the Python scripts to the CI, together with associated cleanup. Cleanup without enforcement is not going to stick. |
Agree with @jbytheway, this isn't going to meaningfully fix anything and 'd rather not churn code over it if we can't make it stick. |
Summary
SUMMARY: Bugfixes "Removes several unneeded spaces."
Purpose of change
Describe the solution
Describe alternatives you've considered
Testing
Additional context