allow creatures to be considered valid targets for examine highlighting #37692
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "allow creatures to be considered valid targets for examine highlighting"
Purpose of change
After #37597 it became impossible to examine tiles with creatures in them if there were no other examinables nearby, due to the examine highlighting not considering creatures valid examine targets.
Describe the solution
add a check for creatures in the
can_examine_at()
logicDescribe alternatives you've considered
reverting the change to examine to emit an error message if nothing to examine is nearby
it's possible to make the test more nuanced (since the examine logic has several things it checks for in determining if a creature can be interacted with), but I felt attempting to duplicate those checks would be too brittle.
Testing
loaded game, examined tamed horse, npc, etc. both with and without "autoselect if exactly one valid target" enabled