Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow creatures to be considered valid targets for examine highlighting #37692

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

esotericist
Copy link
Contributor

Summary

SUMMARY: Bugfixes "allow creatures to be considered valid targets for examine highlighting"

Purpose of change

After #37597 it became impossible to examine tiles with creatures in them if there were no other examinables nearby, due to the examine highlighting not considering creatures valid examine targets.

Describe the solution

add a check for creatures in the can_examine_at() logic

Describe alternatives you've considered

reverting the change to examine to emit an error message if nothing to examine is nearby

it's possible to make the test more nuanced (since the examine logic has several things it checks for in determining if a creature can be interacted with), but I felt attempting to duplicate those checks would be too brittle.

Testing

loaded game, examined tamed horse, npc, etc. both with and without "autoselect if exactly one valid target" enabled

@esotericist esotericist added Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) labels Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants