-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CR][MMA mod] Add Panzer Kunst as fictional martial art #29150
Conversation
Ugh, could someone please make those astyle/lint/whatever formatting checks print out useful information as opposed to "Error 1"? I matched the formatting of the main repo |
If you're compiling, you should be able to just run the linter locally. |
data/mods/MMA/professions.json
Outdated
"type": "profession", | ||
"ident": "mma_battle_angel", | ||
"name": "Battle Angel", | ||
"description": "A combat cyborg built in the image of a girl...", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably avoid using gendered language here. This description would be odd for a male Battle Angel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically a born male human could still use a female-shaped robot body but you're probably right, best to avoid the subject unless actually desired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The body is capable of changing genders. When we first see it in the maga, its male. Also, angels can be male.
I haven't seen Alita, but I think the reference is cool. On a related note, I could send this to my German friend and give them an aneurysm if I wanted, which I think is always a plus. |
Can relate, speak German and read the entire Vandenreich arc in Bleach. All grammatical mistakes and poor word choices are completely intentional, although do feel free to point out typos/spelling mistakes. |
Summary
SUMMARY: Mods "Added Panzer Kunst to fictional martial arts mod"
Purpose of change
Per request of @kd8qdz I looked into Panzer Kunst from the Alita universe as a fictional martial art.
Full disclosure: I have neither read nor watched Alita so my reference material is limited to the fandom wiki and about 5min each of trailer and ye olde OVA battle footage.
I also re-added my previous fix to #28874 (already done in #29027, accidentally reverted in #28892) by re-deleting Five Deadly Venoms martial arts manuals from the base game loot table.moved to #29160, should have been an independent PR from the beginningDescribe the solution
The main feature of this art is an armour-ignoring super punch supposedly utilising high-frequency vibration. Other techniques and mechanics focus on damage avoidance with a preference for dodging coupled with quick offense as this seemed to match Alita's performance the best. Explicitly machine-exclusive aspects such as plasma cloaks, bullets/bombs or abnormal limb movement are avoided but CBM weapons and limb plating are compatible.
Since, let's face it, most people looking for this will be wanting to cosplay Alita I also added a starting profession for that purpose, based primarily on her OVA appearance as "Gally".
Describe alternatives you've considered
Additional context