Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CR][MMA mod] Add Panzer Kunst as fictional martial art #29150

Merged
merged 10 commits into from
May 18, 2019

Conversation

Photoloss
Copy link
Contributor

@Photoloss Photoloss commented Mar 30, 2019

Summary

SUMMARY: Mods "Added Panzer Kunst to fictional martial arts mod"

Purpose of change

Per request of @kd8qdz I looked into Panzer Kunst from the Alita universe as a fictional martial art.

Full disclosure: I have neither read nor watched Alita so my reference material is limited to the fandom wiki and about 5min each of trailer and ye olde OVA battle footage.

I also re-added my previous fix to #28874 (already done in #29027, accidentally reverted in #28892) by re-deleting Five Deadly Venoms martial arts manuals from the base game loot table. moved to #29160, should have been an independent PR from the beginning

Describe the solution

The main feature of this art is an armour-ignoring super punch supposedly utilising high-frequency vibration. Other techniques and mechanics focus on damage avoidance with a preference for dodging coupled with quick offense as this seemed to match Alita's performance the best. Explicitly machine-exclusive aspects such as plasma cloaks, bullets/bombs or abnormal limb movement are avoided but CBM weapons and limb plating are compatible.

Since, let's face it, most people looking for this will be wanting to cosplay Alita I also added a starting profession for that purpose, based primarily on her OVA appearance as "Gally".

Describe alternatives you've considered

  • If anyone knows a way of making the counterattack technique unable to crit (not making it crit-only!) please tell, even with the movement requirement I feel it does too much damage on crits.
  • The core components of this (and other) modded martial arts could be moved to the core game JSON, since the mods are shipped with releases anyway the code is not technically "dead". This would allow other mods (e.g. Aftershock in this case) to also enable access and loading blocker mods ("No Scifi" or "No Medieval") after the MMA mod should be able to selectively filter out certain arts. This idea stems from the current state of the Deadly Venoms which clearly is a compromise for the sake of backwards compatibility so I kept everything in the mod for now.

Additional context

  • The MA, buff and technique names are supposed to be in mangled German. Please do not translate/correct them without direct reference to the source material.
  • If someone who actually has in-depth knowledge of the franchise could look over this that'd be great
  • Everything works fine on my English ubuntu but some strings contain German letters ("ü", "ß"), hopefully this won't cause issues in e.g. Terminal or minimalist builds.

@Photoloss Photoloss changed the title [MMA mod] Add Panzer Kunst as fictional martial art [MMA mod][CR] Add Panzer Kunst as fictional martial art Mar 30, 2019
@Photoloss
Copy link
Contributor Author

Ugh, could someone please make those astyle/lint/whatever formatting checks print out useful information as opposed to "Error 1"? I matched the formatting of the main repo mutations.json yet somehow this is not accepted for the mod version? I even re-compiled the newest version and it auto-formatted the other added files so why are those checks failing?

@kevingranade
Copy link
Member

If you're compiling, you should be able to just run the linter locally.

@Photoloss Photoloss changed the title [MMA mod][CR] Add Panzer Kunst as fictional martial art [CR][MMA mod] Add Panzer Kunst as fictional martial art Mar 31, 2019
"type": "profession",
"ident": "mma_battle_angel",
"name": "Battle Angel",
"description": "A combat cyborg built in the image of a girl...",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably avoid using gendered language here. This description would be odd for a male Battle Angel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically a born male human could still use a female-shaped robot body but you're probably right, best to avoid the subject unless actually desired.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The body is capable of changing genders. When we first see it in the maga, its male. Also, angels can be male.

@mlangsdorf mlangsdorf added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Melee Melee weapons, tactics, techniques, reach attack labels Apr 1, 2019
@Ilysen
Copy link
Contributor

Ilysen commented Apr 9, 2019

I haven't seen Alita, but I think the reference is cool. On a related note, I could send this to my German friend and give them an aneurysm if I wanted, which I think is always a plus.

@Photoloss
Copy link
Contributor Author

On a related note, I could send this to my German friend and give them an aneurysm if I wanted, which I think is always a plus.

Can relate, speak German and read the entire Vandenreich arc in Bleach. All grammatical mistakes and poor word choices are completely intentional, although do feel free to point out typos/spelling mistakes.

@ZhilkinSerg ZhilkinSerg self-assigned this May 18, 2019
@ZhilkinSerg ZhilkinSerg merged commit c763e19 into CleverRaven:master May 18, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Melee Melee weapons, tactics, techniques, reach attack Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants