-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a mod for fictional martial arts #29027
Conversation
Could you please describe what is unsuitable in those martial arts? |
@Wokko1 The removal was not my decision, see #28874. These "martial arts" are not practiced anywhere in the real world, not even in a modern sporting/competition context. They basically don't exist and the way they are portrayed in the movie certainly would not function in real life (especially the Lizard essentially "standing" on a vertical wall as if they could rotate gravity). The good news for you is that the styles should remain in the base game for a lengthy period of time for the sake of backwards compatibility, and you can edit the |
data/mods/MMA/modinfo.json
Outdated
"type": "MOD_INFO", | ||
"ident": "MMA", | ||
"name": "Mythical Martial Arts", | ||
"authors": [ "Photoloss", "C:DDA main repo" ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing C:DDA main repo
is meant for anyone to add, edit or otherwise modify?
I'd suggest removing the line and adding a second line:
"authors": [ "Photoloss", "C:DDA main repo" ], | |
"authors": [ "Photoloss" ], | |
"maintainers": [ "Anyone" ], |
Hopefully makes it understood that anyone can make changes to it. I'm not 100% sure on the guidelines for stuff like this, but typically any "official" mods are "anyone and everyone"'s responsibility, so it might be moot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main point from my side was that I am not actually the "original author" of the code for the martial arts. If I were to post chapters from Alice in Wonderland on a blog for example the credited "author" should be Lewis Carroll and not myself as the blog owner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove authors
and maintainers
nodes - they aren't necessary.
realism strikes again |
It is actually a strike back at realism. |
Can we add Panzer Kunst? |
@kd8qdz Well I have no idea what that is and it does not seem to be a JoJo reference so you'll have to provide some more info. As long as it's roughly on the same power level as regular MAs (so nothing ridiculous like Saiyan airborne combat) I am not aware of any particular reason not to add to a mod. |
@Photoloss https://battleangel.fandom.com/wiki/Panzer_Kunst So probably another version of Bionic Combatives. I would've linked it to you in Discord, but I don't see you on there. |
Summary
SUMMARY: Mods "Re-adds fictional martial arts as a mod"
Purpose of change
Content being outright removed is never all that fun, but the Five Deadly Venoms definitely do not suit the base game's penchant for realism. This mod is not solely intended to restore access to these arts but also as a go-to alternative for any future additions deemed unsuitable for the base game.
Describe the solution
Describe alternatives you've considered
martialarts_fictional.json
could be redistributed to the standard locations for their types, current examples are inconsistent.