Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a mod for fictional martial arts #29027

Merged
merged 4 commits into from
Mar 27, 2019
Merged

Conversation

Photoloss
Copy link
Contributor

Summary

SUMMARY: Mods "Re-adds fictional martial arts as a mod"

Purpose of change

Content being outright removed is never all that fun, but the Five Deadly Venoms definitely do not suit the base game's penchant for realism. This mod is not solely intended to restore access to these arts but also as a go-to alternative for any future additions deemed unsuitable for the base game.

Describe the solution

  • Remove Five Deadly Venoms martial arts manuals from dojo drop tables (may be an oversight from Deprecate fictional martial arts. #28874)
  • Keep martial art definitions in the base game for backwards compatibility, file renamed to avoid future deletion
  • Add a small mod granting access to the Venom Mob starting trait as well as restoring the martial arts manuals as dojo loot

Describe alternatives you've considered

  • The contents of martialarts_fictional.json could be redistributed to the standard locations for their types, current examples are inconsistent.
  • There might be a better phrasing for the mod authors. I do not claim authorship of any functional content of the mod as it was simply copied from the base game but do not want to shirk responsibility for it either.

@Wokko1
Copy link
Contributor

Wokko1 commented Mar 26, 2019

Could you please describe what is unsuitable in those martial arts?
I never used those, but they add variety to the game.

@Photoloss
Copy link
Contributor Author

@Wokko1 The removal was not my decision, see #28874. These "martial arts" are not practiced anywhere in the real world, not even in a modern sporting/competition context. They basically don't exist and the way they are portrayed in the movie certainly would not function in real life (especially the Lizard essentially "standing" on a vertical wall as if they could rotate gravity).

The good news for you is that the styles should remain in the base game for a lengthy period of time for the sake of backwards compatibility, and you can edit the mods.json in your world save file to add this mod restoring everything without having to restart. At least that is the current intent.

"type": "MOD_INFO",
"ident": "MMA",
"name": "Mythical Martial Arts",
"authors": [ "Photoloss", "C:DDA main repo" ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing C:DDA main repo is meant for anyone to add, edit or otherwise modify?

I'd suggest removing the line and adding a second line:

Suggested change
"authors": [ "Photoloss", "C:DDA main repo" ],
"authors": [ "Photoloss" ],
"maintainers": [ "Anyone" ],

Hopefully makes it understood that anyone can make changes to it. I'm not 100% sure on the guidelines for stuff like this, but typically any "official" mods are "anyone and everyone"'s responsibility, so it might be moot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main point from my side was that I am not actually the "original author" of the code for the martial arts. If I were to post chapters from Alice in Wonderland on a blog for example the credited "author" should be Lewis Carroll and not myself as the blog owner.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove authors and maintainers nodes - they aren't necessary.

@DracoGriffin DracoGriffin added [JSON] Changes (can be) made in JSON Melee Melee weapons, tactics, techniques, reach attack Mods Issues related to mods or modding labels Mar 26, 2019
@ZhilkinSerg ZhilkinSerg self-assigned this Mar 27, 2019
@ZhilkinSerg ZhilkinSerg merged commit 8ae75ac into CleverRaven:master Mar 27, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment Mar 27, 2019
@adamkad1
Copy link
Contributor

realism strikes again

@ZhilkinSerg
Copy link
Contributor

realism strikes again

It is actually a strike back at realism.

@kd8qdz
Copy link
Contributor

kd8qdz commented Mar 27, 2019

Can we add Panzer Kunst?

@Photoloss
Copy link
Contributor Author

@kd8qdz Well I have no idea what that is and it does not seem to be a JoJo reference so you'll have to provide some more info. As long as it's roughly on the same power level as regular MAs (so nothing ridiculous like Saiyan airborne combat) I am not aware of any particular reason not to add to a mod.

@DracoGriffin
Copy link
Contributor

@kd8qdz Well I have no idea what that is and it does not seem to be a JoJo reference so you'll have to provide some more info. As long as it's roughly on the same power level as regular MAs (so nothing ridiculous like Saiyan airborne combat) I am not aware of any particular reason not to add to a mod.

@Photoloss https://battleangel.fandom.com/wiki/Panzer_Kunst

So probably another version of Bionic Combatives.

I would've linked it to you in Discord, but I don't see you on there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Melee Melee weapons, tactics, techniques, reach attack Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants