-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It is possible to scan books in merchant's inventory without buying them #65840
Labels
(S1 - Need confirmation)
Report waiting on confirmation of reproducibility
Comments
Demivan
added
the
(S1 - Need confirmation)
Report waiting on confirmation of reproducibility
label
May 24, 2023
Perhaps they are releasing the books under the CC BY-SA 3.0 license. |
Does this have to do with being able to scan unread books now which doesn't pick them up? |
it almost certainly does since this also apples to books that are flagged as owned but not being carried by anyone (like all the books in the refugee center). |
Demivan
added a commit
to Demivan/Cataclysm-DDA
that referenced
this issue
May 30, 2023
Don't allow to scan books that are owned by other character # Explain why this change is being made # |<---- Limit Each Line to a Maximum Of 72 Characters ---->| It was possible to scan books from merchant inventory without buying them. # Provide links or keys to any relevant tickets, articles or other resources # Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567 fixes CleverRaven#65840
Demivan
added a commit
to Demivan/Cataclysm-DDA
that referenced
this issue
May 30, 2023
It was possible to scan books from merchant inventory without buying them. fixes CleverRaven#65840
Maleclypse
pushed a commit
that referenced
this issue
Jun 19, 2023
* Don't allow to scan books that are owned by other character It was possible to scan books from merchant inventory without buying them. fixes #65840 * Fix formating Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
It is possible to scan books that are in merchant's (probably in any other character) inventory without buying them.
In merchant's case, this leads to getting all his books for free.
Attach save file
N/A
Steps to reproduce
Expected behavior
Books in merchant's and other character inventories should not be scannable.
Screenshots
After successful scan:
Versions and configuration
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
Portal Storms Ignore NPCs [personal_portal_storms],
No Fungal Growth [no_fungal_growth],
Bionic Professions [package_bionic_professions],
Xedra Evolved [xedra_evolved],
Mythical Martial Arts [MMA],
No Rail Stations [No_Rail_Stations],
Tamable Wildlife [Tamable_Wildlife]
]
Additional context
No response
The text was updated successfully, but these errors were encountered: