Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve default keybindings to avoid suicide by mistake #2345

Closed
Zireael07 opened this issue Aug 7, 2013 · 8 comments
Closed

Improve default keybindings to avoid suicide by mistake #2345

Zireael07 opened this issue Aug 7, 2013 · 8 comments
Labels
<Enhancement / Feature> New features, or enhancements on existing

Comments

@Zireael07
Copy link
Contributor

I suggest moving S to Quicksave and Q to Save and Quit by default.

This would mean that to suicide you'd need to quit the game (without having saved) using the 'x' or whatever the method on your OS is.
@kevingranade
Copy link
Member

I'm not sure we handle OS exists like that properly, which is something to look out for. How do you suicide by mistake anyway, you have to do Q and then Y.

@whitelight04
Copy link

Probably because you have to do a S and then a Y to save and quit and on two occasions I accidentally did a Q first myself as I was not really thinking about it since I have used Q for quitting out other games before. I do blame myself for the stupidity of it but the binding for it seems to come back every time I get rid of it.

@ianestrachan
Copy link
Contributor

A potential idea is making it so you have to fully type "yes" to confirm a suicide, or using some other pair of commands ([C]onfirm/[D]eny, [A]llow/[F]orbid, [S]uicide/[L]ive, etc). Or possibly having two prompts instead of one ("Are you SURE you want to commit suicide?").

@Zireael07
Copy link
Contributor Author

@ianestrachan: This is a good idea.

@kevingranade
Copy link
Member

If this is really an issue for you, unbind the suicide key. Also there's a
pending issue that will make suicide/death reversable.
On Aug 8, 2013 10:15 AM, "Zireael07" [email protected] wrote:

@ianestrachan https://github.com/ianestrachan: This is a good idea.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/2345#issuecomment-22330389
.

@KA101
Copy link
Contributor

KA101 commented Aug 11, 2013

OS exits, at least in Windows, are quit w/o saving. Comes in handy.

@kevingranade
Copy link
Member

Suicide now has a double-confirm.

@DeltaR9A2
Copy link

If you wanted to get sufficiently detailed and morbid, maybe suicide should be an in-game action. IE the character has to [a]pply a sharp object to his neck or [f]ire a gun at his head.

Suicide is a pretty awful subject though, so it could be a bad idea to go into unnecessary detail on it.

Yunatan added a commit to Yunatan/Cataclysm-DDA that referenced this issue Apr 24, 2019
@Yunatan
# If this commit is applied, it will ....
7a682ff 
# |<-- Using around 50, Maximum 72 Characters -->|
Allow character to see an opaque tile while standing on another adjacent opaque tile.

# Explain why this change is being made
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|

# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567
Fixes CleverRaven#28694
matskuman5 added a commit to matskuman5/Cataclysm-DDA that referenced this issue Jun 5, 2019
@matskuman5
# If this commit is applied, it will ....
81d2052 
fix some monster description typos

# Explain why this change is being made
grammatical reasons

# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567
kevingranade pushed a commit that referenced this issue Jun 5, 2019
@matskuman5 @kevingranade
# If this commit is applied, it will ....
c5796f3 
fix some monster description typos

# Explain why this change is being made
grammatical reasons

# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes #1234, closes #2345, resolves #3456, references #4567
EddiTheBambi added a commit to EddiTheBambi/Cataclysm-DDA that referenced this issue Jul 31, 2019
@EddiTheBambi
# If this commit is applied, it will ....
c5f0e4c 
Hammering 1 requirement for picking up frozen liquids

# Explain why this change is being made
Player can't scoop up solid ice with their hands, need something to chip off chunks with

# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567
Kiktamo added a commit to Kiktamo/Cataclysm-DDA that referenced this issue Jul 11, 2020
@Kiktamo
# If this commit is applied, it will ....
bdecc23 
# |<-- Using around 50, Maximum 72 Characters -->|
Adds freeze dryer. Adds dehydrated royal jelly. Spoilage for Royal Jelly
# Explain why this change is being made
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|
Works toward resolving CleverRaven#41361
# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567
misterprimus added a commit to misterprimus/Cataclysm-DDA that referenced this issue Jan 1, 2021
@misterprimus
# If this commit is applied, it will ....
24455b7 
# |<-- Using around 50, Maximum 72 Characters -->|

# Explain why this change is being made
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|

# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567
redrosedialtone added a commit to redrosedialtone/Cataclysm-DDA that referenced this issue Mar 20, 2022
@redrosedialtone
Refactoring
d6020c1 
# Explain why this change is being made
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|

# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567
redrosedialtone added a commit to redrosedialtone/Cataclysm-DDA that referenced this issue Mar 20, 2022
@redrosedialtone
[Medical Menu] Code Clarity
1f050a6 
# |<-- Using around 50, Maximum 72 Characters -->|

# Explain why this change is being made
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|

# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567
redrosedialtone added a commit to redrosedialtone/Cataclysm-DDA that referenced this issue Mar 22, 2022
@redrosedialtone
[Medical Menu] C++ Analysis
1700441 
# |<-- Using around 50, Maximum 72 Characters -->|

# Explain why this change is being made
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|

# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567
redrosedialtone added a commit to redrosedialtone/Cataclysm-DDA that referenced this issue Mar 27, 2022
@redrosedialtone
[Medical Menu] Static efftype_id
f1c9717 
# |<-- Using around 50, Maximum 72 Characters -->|

# Explain why this change is being made
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|

# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567
OldFriendEr added a commit to OldFriendEr/Cataclysm-DDA that referenced this issue Apr 9, 2022
@OldFriendEr
will handle breathability override invalid values
759084c 
# |<-- Using around 50, Maximum 72 Characters -->|

armor part breathability will be calculated if override has invalid
value set
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|

# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567
I-am-Erk pushed a commit that referenced this issue Apr 16, 2022
@OldFriendEr @faefux
@BrettDong @Night-Pryanik @chaohedgehogs @Rivet-the-Zombie @esotericist @haveric @bombasticSlacks
Ability to override armor breathability (#56691)
969e521 
* Flight gear

* Update data/json/items/tool_armor.json

Co-authored-by: Binrui Dong <[email protected]>

* Update data/json/items/tool_armor.json

Co-authored-by: Anton Burmistrov <[email protected]>

* Update data/json/items/tool_armor.json

Co-authored-by: chaohedgehogs <[email protected]>

* Update data/json/items/tool_armor.json

Co-authored-by: chaohedgehogs <[email protected]>

* Update data/json/items/tool_armor.json

Co-authored-by: Binrui Dong <[email protected]>

* Update tool_armor.json

Added Two-Way Radio to the helmet when on, in-built radio was a common functionality with the helmets I researched.

* Update 9mm.json

9x19mm +P+ is about double the price of 9x19mm +P as per my cursory research.

* Update suits_protection.json

* Update tool_armor.json

* Update 9mm.json

* Revert "9x19mm +P and + prices" (#49155)

* enable to override armor breathability using JSON

The breathability currently is being calculated by the least breathable
material, in some cases it contradicts the item description in this case
the nomad_bodyglove_1, witch is breathable, but has breathability 0 due
to some rubber in it. Now it can be set from JSON file. I also adjusted
the nomad_bodyglove_1 breathability values by using material
breathability of lycra and cotton.

* Update src/itype.h

Co-authored-by: haveric <[email protected]>

* will handle breathability override invalid values
# |<-- Using around 50, Maximum 72 Characters -->|

armor part breathability will be calculated if override has invalid
value set
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|

# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes #1234, closes #2345, resolves #3456, references #4567

* breathability override no uses enum
# |<-- Using around 50, Maximum 72 Characters -->|

had a suggestion not to use arbitrary values but use defined enums
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|

* Update src/material.h

Co-authored-by: Dillon Matchett <[email protected]>

* linted JSON

custom_underwear.json was not linted, now its good

Co-authored-by: faefux <[email protected]>
Co-authored-by: fae <[email protected]>
Co-authored-by: Binrui Dong <[email protected]>
Co-authored-by: Anton Burmistrov <[email protected]>
Co-authored-by: chaohedgehogs <[email protected]>
Co-authored-by: Angela Graves <[email protected]>
Co-authored-by: eso <[email protected]>
Co-authored-by: haveric <[email protected]>
Co-authored-by: Dillon Matchett <[email protected]>
dseguin pushed a commit that referenced this issue Apr 18, 2022
@redrosedialtone @Maleclypse @kevingranade
Medical Menu Implementation (#54763)
cf799ab 
* Medical Menu Implementation

Implements the initial steps for the Medical Menu, changes including;
~keybindings.json - Adds 'View Medical' hotkey under 'N'
~action.cpp / ~action.h / ~avatar.h / handle_action.cpp / game.cpp - Adds the corresponding action to 'View Medical'
+medical_ui.cpp - Menu implementation
~display.h / display.cpp - Exposes bodypart_status_colors

* [Medical Menu] Basic Build and Test (GCC 9, Curses, LTO) Styling

Removal of a couple variables left behind from previous implementation, correct character casting.

* [Medical Menu] Extended Implementation

-Access from Player Info ('@') Menu
-Info Menu
-Scrolling Text
-Formatting
-Astyle & Clang Tidy

* [Medical Menu] Removal of widget dependency

Removed temporarily until the widget implementation is less in-progress; Code cleanup.

* Update data/raw/keybindings.json

* Refactoring



# Explain why this change is being made
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|

# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes #1234, closes #2345, resolves #3456, references #4567

* [Medical Menu] Code Clarity

# |<-- Using around 50, Maximum 72 Characters -->|

# Explain why this change is being made
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|

# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes #1234, closes #2345, resolves #3456, references #4567

* [Medical Menu] C++ Analysis

# |<-- Using around 50, Maximum 72 Characters -->|

# Explain why this change is being made
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|

# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes #1234, closes #2345, resolves #3456, references #4567

* Update src/medical_ui.cpp

* [Medical Menu] Static efftype_id

# |<-- Using around 50, Maximum 72 Characters -->|

# Explain why this change is being made
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|

# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes #1234, closes #2345, resolves #3456, references #4567

Co-authored-by: Maleclypse <[email protected]>
Co-authored-by: Kevin Granade <[email protected]>
OldFriendEr added a commit to OldFriendEr/Cataclysm-DDA that referenced this issue Jun 8, 2022
@OldFriendEr
add slime, bird samples to the rest sample spawns
60858f8 
# |<-- Using around 50, Maximum 72 Characters -->|

those two particular samples were missing in the loot-table
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|

closes CleverRaven#58255
# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567
bombasticSlacks pushed a commit that referenced this issue Jun 8, 2022
@OldFriendEr
add slime, bird samples to the rest sample spawns (#58270)
2ec0e5e 
# |<-- Using around 50, Maximum 72 Characters -->|

those two particular samples were missing in the loot-table
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|

closes #58255
# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes #1234, closes #2345, resolves #3456, references #4567
bombasticSlacks pushed a commit to bombasticSlacks/Cataclysm-DDA that referenced this issue Jun 10, 2022
@OldFriendEr @bombasticSlacks
add slime, bird samples to the rest sample spawns (CleverRaven#58270)
71459d8 
# |<-- Using around 50, Maximum 72 Characters -->|

those two particular samples were missing in the loot-table
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|

closes CleverRaven#58255
# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567
kebkaldanil added a commit to kebkaldanil/Cataclysm-DDA that referenced this issue Oct 13, 2022
@kebkaldanil
fix clang compilation errors and misspeling
a4b91c0 
# Explain why this change is being made
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|
There was some clang compilation errors and misspeling in previous commits

# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567
Demivan added a commit to Demivan/Cataclysm-DDA that referenced this issue May 30, 2023
@Demivan
# If this commit is applied, it will ....
4d896b1 
Don't allow to scan books that are owned by other character

# Explain why this change is being made
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|
It was possible to scan books from merchant inventory without
buying them.

# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567
fixes CleverRaven#65840
OldFriendEr added a commit to OldFriendEr/Cataclysm-DDA that referenced this issue Dec 7, 2023
@OldFriendEr
fix weapon steadiness bar not working
3bb14d7 
# |<-- Using around 50, Maximum 72 Characters -->|

due to a bug the bar only shows up when steadiness is full, problem was
that the calculated steadiness was stored in an int while the value was
a double resulting in either empty or full bar.
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|

# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567
fixes CleverRaven#69954
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
<Enhancement / Feature> New features, or enhancements on existing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@DeltaR9A2 @kevingranade @ianestrachan @KA101 @Zireael07 @whitelight04