Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some samples are missing from TLC and micro lab loot #58255

Closed
OldFriendEr opened this issue Jun 7, 2022 · 0 comments · Fixed by #58270
Closed

Some samples are missing from TLC and micro lab loot #58255

OldFriendEr opened this issue Jun 7, 2022 · 0 comments · Fixed by #58270
Labels
Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON (S2 - Confirmed) Bug that's been confirmed to exist Spawn Creatures, items, vehicles, locations appearing on map

Comments

@OldFriendEr
Copy link
Contributor

Describe the bug

Currently the bird and slime samples will not spawn in TLCs and microlabs.
Alpha and medical also have no spawns, but i get those are special

Steps to reproduce

Best way to check is to visit a TLC cargo area that spawn boxes with random samples.

Expected behavior

At least i expect to find slime and bird samples in regular TLC, microlab loot tables, because they do not seem exotic

Screenshots

No response

Versions and configuration

  • 68afa17 (tiles)
  • Experimental Build 2022-06-07-1738

Additional context

No response
@OldFriendEr OldFriendEr added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jun 7, 2022
@Maleclypse Maleclypse added Good First Issue This is a good first issue for a new contributor (S2 - Confirmed) Bug that's been confirmed to exist Spawn Creatures, items, vehicles, locations appearing on map [JSON] Changes (can be) made in JSON and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Jun 7, 2022
OldFriendEr added a commit to OldFriendEr/Cataclysm-DDA that referenced this issue Jun 8, 2022
@OldFriendEr
add slime, bird samples to the rest sample spawns
60858f8 
# |<-- Using around 50, Maximum 72 Characters -->|

those two particular samples were missing in the loot-table
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|

closes CleverRaven#58255
# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567
@OldFriendEr OldFriendEr mentioned this issue Jun 8, 2022
Merged
bombasticSlacks pushed a commit that referenced this issue Jun 8, 2022
@OldFriendEr
add slime, bird samples to the rest sample spawns (#58270)
2ec0e5e 
# |<-- Using around 50, Maximum 72 Characters -->|

those two particular samples were missing in the loot-table
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|

closes #58255
# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes #1234, closes #2345, resolves #3456, references #4567
bombasticSlacks pushed a commit to bombasticSlacks/Cataclysm-DDA that referenced this issue Jun 10, 2022
@OldFriendEr @bombasticSlacks
add slime, bird samples to the rest sample spawns (CleverRaven#58270)
71459d8 
# |<-- Using around 50, Maximum 72 Characters -->|

those two particular samples were missing in the loot-table
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|

closes CleverRaven#58255
# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON (S2 - Confirmed) Bug that's been confirmed to exist Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add slime, bird samples to the sample loot-table OldFriendEr/Cataclysm-DDA
2 participants
@OldFriendEr @Maleclypse