Don't allow to scan books that are owned by other characters #65927
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Don't allow to scan books that are owned by other characters"
Purpose of change
Fixes #65840
It was possible to scan books from merchant inventory without buying them.
Describe the solution
Add
is_owned_by
check when selecting books for the list of books to scan, filtering out books that character does not have access to.Describe alternatives you've considered
Keep displaying all books, but mark owned ones and allow stealing them when scanning.
Testing
Additional context
Seems like there is a similar issue with reading. It allows reading books in refuge center that the character cannot pick up, as that would be stealing.