Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.1.0 #1459

Merged
merged 81 commits into from
Jan 9, 2025
Merged

Release 4.1.0 #1459

merged 81 commits into from
Jan 9, 2025

Conversation

mrTuomoK
Copy link
Contributor

@mrTuomoK mrTuomoK commented Jan 9, 2025

[4.1.0] - January, 09, 2025

React

Added

  • [LoginProviderWithApolloContext] Login Provider with automatic ApolloClient context.
  • [ApolloClientModule] New Login module for auto-appending api tokens to query headers.
  • [ApiTokenClientTracker] Util to track api token changes and renewals.

Changed

Changes that are not related to specific components

  • [GraphQLModule] Use the ApolloClient Module when available

Fixed

  • [Login] External modules with Strict mode throwed an error
  • [ssr] Login component works with SSR rendering
  • [Login] Event listeners with Strict mode were lost in double render

Documentation

Added

  • Technology tags to all components

Figma

Fixed

  • [Header] Other actions menu item color fixed in header dark version.

Deprecated

  • [PhoneInput] Country Code variant was deprecated. Still available in the library but will be removed in the next major release.

Hds-js

Added

  • [ApolloClientModule] New Login module for auto-appending api tokens to query headers.
  • [ApiTokenClientTracker] Util to track api token changes and renewals.

Changed

  • [GraphQLModule] Use the ApolloClient Module when available

mrTuomoK and others added 30 commits November 21, 2024 17:13
The render process could be too fast for Date.now() to change
Select exported old ones and Login was missing
If items are added directly to the module array, the array size increases and same modules are added twice on second render.
…-fix

HDS-2535: login modules strict mode fix
Memoize array in Login.stories and merge 3 useMemos to one in LoginContext
…eated

In a scenario where external modules are used and the component is created multiple times, the listeners are set only once in the modules.

This happens in StrictMode.

On the second storeBeacon call the listeners in dedicated beacon are not added back and old ones are not removed.

The list of listeners must be kept and disposers must be called.

Now listeners are added again.

Listeners added after a beacon is created are not stored, because those are logically added when second beacon is created - as in first run.
…mode

HDS-2535: external modules listeners fix in Strict mode
ApiToken renewal/update/removal can happen regardless of on-going queries. The renewal should also timeout.

This util will track tokens, store them and timeout rewals.

The code logic is copied from graphqlModule.
Copy link

github-actions bot commented Jan 9, 2025

Test Results

  1 files   68 suites   14m 21s ⏱️
 86 tests  86 ✅ 0 💤 0 ❌
172 runs  172 ✅ 0 💤 0 ❌

Results for commit 1d9d979.

♻️ This comment has been updated with latest results.

@mrTuomoK mrTuomoK requested a review from a team January 9, 2025 10:48
Copy link
Contributor

@laurakarhu laurakarhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otsikon korjaus ja onkohan tässä taas edellisten versioiden tauhkaa mukana?

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@laurakarhu laurakarhu self-requested a review January 9, 2025 11:02
@City-of-Helsinki City-of-Helsinki deleted a comment from mrTuomoK Jan 9, 2025
Copy link
Contributor

@laurakarhu laurakarhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me

Copy link
Contributor

@timwessman timwessman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@mrTuomoK mrTuomoK merged commit 34fffa9 into master Jan 9, 2025
9 checks passed
@mrTuomoK mrTuomoK deleted the release-4.1.0 branch January 9, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants