HDS-2535: login modules strict mode fix #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 1 files 64 suites 11m 45s ⏱️ Results for commit f1e35ae. ♻️ This comment has been updated with latest results. |
NikoHelle
force-pushed
the
hds-2535-login-modules-fix
branch
from
08813fc to
753275c
Compare
|
Preview found from hds-demo docs/preview_1442 Demos |
If items are added directly to the module array, the array size increases and same modules are added twice on second render.
NikoHelle
force-pushed
the
hds-2535-login-modules-fix
branch
from
753275c to
f1e35ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If items are added directly to the module array, the array size increases and same modules are added twice on second render.
Related Issue
Closes HDS-2535
Motivation and Context
How Has This Been Tested?
Added strict mode emulation to Login story.
Demos:
Login does not work on demo site.
Screenshots (if appropriate):
Add to changelog