Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDS-2572: dateinput e2e tests #1455

Merged
merged 7 commits into from
Jan 9, 2025
Merged

HDS-2572: dateinput e2e tests #1455

merged 7 commits into from
Jan 9, 2025

Conversation

NikoHelle
Copy link
Contributor

@NikoHelle NikoHelle commented Dec 20, 2024

Description

Convert Jest tests to e2e tests.

Axe and snapshot tests cannot be converted now.

Related Issue

Closes HDS-2572

Motivation and Context

How Has This Been Tested?

Demos:

Links to demos are in the comments

Screenshots (if appropriate):

Add to changelog

  • No need.

Copy link

github-actions bot commented Dec 20, 2024

Test Results

  1 files   68 suites   14m 27s ⏱️
 86 tests  86 ✅ 0 💤 0 ❌
172 runs  172 ✅ 0 💤 0 ❌

Results for commit 1651906.

♻️ This comment has been updated with latest results.

@NikoHelle NikoHelle force-pushed the hds-2572-dateinput-e2e branch from 057371e to 6a41eae Compare December 20, 2024 10:22
Copy link

Preview found from hds-demo docs/preview_1455

Demos

Docs
Core Storybook
React Storybook

Copy link
Contributor

@mrTuomoK mrTuomoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice nice 👍

Copy link
Contributor

@mrTuomoK mrTuomoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... should we remove or skip the old visual tests too?

@NikoHelle
Copy link
Contributor Author

Oh yes, should add skip to those.

@mrTuomoK mrTuomoK self-requested a review January 7, 2025 13:31
Copy link
Contributor

@mrTuomoK mrTuomoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved my own changes :D

@mrTuomoK mrTuomoK merged commit 632f920 into development Jan 9, 2025
8 checks passed
@mrTuomoK mrTuomoK deleted the hds-2572-dateinput-e2e branch January 9, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants