-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UHF-8909: Preprocess refactoring #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter, of which we can add the current page language and alternative language as default variables to each preprocess, but with less expensive way.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
=========================================
Coverage 89.00% 89.00%
Complexity 518 518
=========================================
Files 76 76
Lines 2064 2064
=========================================
Hits 1837 1837
Misses 227 227 ☔ View full report in Codecov by Sentry. |
This was referenced Jul 26, 2024
tuutti
approved these changes
Jul 29, 2024
Quality Gate passedIssues Measures |
2 tasks
tuutti
approved these changes
Jul 30, 2024
This was referenced Jul 30, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UHF-8909
What was done
hook_template_preprocess_default_variables_alter()
function, where we can add the current page language and alternate language as default variables for each preprocess, but in a cheaper way.How to install
git checkout UHF-8909
make fresh
make drush-cr
How to test
{{ language.id }}
and/or{{ alternative_language }}
Continuous documentation
Automatic- / Regression tests
make test-pw
)Other PRs