Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-8909 District languages #904

Merged
merged 35 commits into from
Aug 30, 2024
Merged

UHF-8909 District languages #904

merged 35 commits into from
Aug 30, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Jul 29, 2024 •
edited by teroelonen
Loading

UHF-8909

What was done

  • Use language manager to get current language.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-8909
    • make fresh
  • Run make drush-cr

How to test

  • Check that the district titles are correctly translated on a project page

    image

  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

teroelonen and others added 29 commits October 11, 2023 11:44
@teroelonen
Merge pull request #708 from City-of-Helsinki/dev
c58dbf4 
Dev to main
@khalima
Merge pull request #716 from City-of-Helsinki/dev
f2cb87b 
Dev to main
@rpnykanen
Merge pull request #721 from City-of-Helsinki/dev
5553761 
Dev to main
@khalima
Merge pull request #727 from City-of-Helsinki/dev
e656152 
Dev to main
@khalima
Merge pull request #733 from City-of-Helsinki/dev
a911dff 
Dev to main
@khalima
Merge pull request #736 from City-of-Helsinki/dev
341ea7a 
Dev to main
@khalima
Merge pull request #747 from City-of-Helsinki/dev
47bf3a1 
Dev to main
@rpnykanen
Merge pull request #760 from City-of-Helsinki/dev
d8544d9 
Dev to main
@khalima
Merge pull request #772 from City-of-Helsinki/dev
c486440 
Dev to main
@rpnykanen
Merge pull request #775 from City-of-Helsinki/dev
c5b8d81 
Dev to main
@khalima
Merge pull request #778 from City-of-Helsinki/dev
ddc0756 
Dev to main
@khalima
Merge pull request #783 from City-of-Helsinki/dev
d3bca30 
Dev to main
@teroelonen
Merge pull request #793 from City-of-Helsinki/dev
c9ea214 
Dev to main
@rpnykanen
Merge pull request #802 from City-of-Helsinki/dev
db27a26 
Dev to main
@rpnykanen
Merge pull request #807 from City-of-Helsinki/dev
c4475e7 
Dev to main
@rpnykanen
Merge pull request #809 from City-of-Helsinki/dev
033c2d5 
Dev to main
@rpnykanen
Merge pull request #817 from City-of-Helsinki/dev
09a6f85 
Dev to main
@khalima
Merge pull request #828 from City-of-Helsinki/dev
945efef 
Dev to main
@khalima
Merge pull request #843 from City-of-Helsinki/dev
ca37216 
Dev to main
@rpnykanen
Merge pull request #845 from City-of-Helsinki/dev
272023b 
Dev to main
@teroelonen
Merge pull request #854 from City-of-Helsinki/dev
3312d2b 
Dev to main
@rpnykanen
Merge pull request #856 from City-of-Helsinki/dev
0db4b72 
Dev to main
@rpnykanen
Merge pull request #871 from City-of-Helsinki/dev
aded5d6 
Dev to main
@rpnykanen
Merge pull request #877 from City-of-Helsinki/dev
5c58641 
Dev to main
@rpnykanen
Merge pull request #882 from City-of-Helsinki/dev
81188e3 
Dev to main
@rpnykanen
Merge pull request #886 from City-of-Helsinki/dev
0b0d9c0 
Dev to main
@hyrsky
Merge pull request #890 from City-of-Helsinki/dev
e5ebe08 
Dev to main
@hyrsky
Merge pull request #895 from City-of-Helsinki/dev
38f1cbf 
Dev to main
@khalima
UHF-8909: Use language manager to get current language.
e136944
@khalima khalima mentioned this pull request Jul 30, 2024
Merged
17 tasks
This was referenced Jul 30, 2024
Merged
Merged
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

teroelonen
teroelonen requested changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This with hdbt changes causes currently InvalidArgumentException: The URI '' is invalid. You must use a valid URI scheme. in Drupal\Core\Url::fromUri() (line 293 of core/lib/Drupal/Core/Url.php). on front page of the instance.

teroelonen
teroelonen approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good 🦖

@khalima khalima merged commit dac3037 into dev Aug 30, 2024
2 checks passed
@khalima khalima deleted the UHF-8909 branch August 30, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khalima @teroelonen @rpnykanen @hyrsky