Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-8909: Use language manager variable to get current language. #22

Merged
merged 1 commit into from
Sep 2, 2024
Merged

UHF-8909: Use language manager variable to get current language. #22

merged 1 commit into from
Sep 2, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Jul 29, 2024 •
edited by jira bot
Loading

UHF-8909

What was done

  • Use language manager variable to get current language.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-0000_insert_correct_branch
    • make fresh
  • Run make drush-cr

How to test

  • Check that the front page search submit points to correct translation, I.e. When clicking submit in Finnish, you'll end up on a Finnish translation of the results page.
  • Check that code follows our standards

Other PRs

This was referenced Jul 30, 2024
Merged
Merged
Merged
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

teroelonen
teroelonen approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct 🦖

@khalima khalima changed the base branch from dev to update-configuration September 2, 2024 07:21
@khalima khalima merged commit fafbbcc into update-configuration Sep 2, 2024
2 checks passed
@khalima khalima deleted the UHF-8909 branch September 2, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalima @teroelonen