-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UHF-10079, UHF-10045 #332
Merged
UHF-10079, UHF-10045 #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khalima
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to work the same way as in current production environment. Good job! 🚀
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UHF-10079
What was done
helfi_platform_config
.How to install
git checkout dev
make fresh
git checkout UHF-10045
composer install
composer update drupal/helfi_platform_config
drush ev "\Drupal::service('update.update_hook_registry')->setInstalledVersion('helfi_ckeditor', 9009);"
drush deploy
make drush-cr
How to test
Review changes to
helfi_ckeditor
inhelfi_platform_config
:git diff 4.3.26..main modules/helfi_ckeditor
. Is there anything that breaks in Infofinland?Artifact needs to be built from this branch for tests to complete.
Continuous documentation
Translations
Other PRs