Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10045: user ban/delete #797

Merged
merged 6 commits into from
Aug 27, 2024
Merged

UHF-10045: user ban/delete #797

merged 6 commits into from
Aug 27, 2024

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Aug 26, 2024

UHF-10045

What was done

  • Move code from infofinland to helfi_platform_config
  • Clarify instructions shown in user_cancel form.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-10045
  • Run make drush-updb drush-cr

How to test

  • Delete user with a admin role.
  • Do you understand guidance on user cancel form?
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

  • Link to other PR

@hyrsky hyrsky force-pushed the UHF-10045 branch 2 times, most recently from 37a888c to c2bffee Compare August 26, 2024 05:48
Copy link

@juho-lehmonen juho-lehmonen self-requested a review August 26, 2024 10:01
Copy link
Contributor

@juho-lehmonen juho-lehmonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but this phrasing raised some questions: "If the account is no longer needed, it should be deleted."

Could this cause some misunderstandings and accidental data loss if we have the "Delete the account and its content" option available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants