Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10555: Deprecated image style cleanup #941

Merged
merged 1 commit into from
Dec 5, 2024
Merged

UHF-10555: Deprecated image style cleanup #941

merged 1 commit into from
Dec 5, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Dec 3, 2024

UHF-10555

What was done

  • Refactor field_districts away from health station fallback search since it is not used in the React version of the search either.

How to install

  • Make sure your instance is up and running on latest dev branch.
  • make fresh
  • Checkout this feature branch and make sure that helfi_platform config is running on correct branch.
    • git fetch && git checkout UHF-10555
    • composer require drupal/helfi_platform_config:dev-UHF-10555
  • Run make drush-cr drush-cim drush-updb

How to test

  • Go to https://helfi-sote.docker.so/fi/sosiaali-ja-terveyspalvelut/terveydenhoito/terveysasemat and turn off javascript. Refresh the page and you should get health station fallback search.
  • On the fallback search make sure that on the placeholder text on the text-input it now says "For example, Haaga Health Station" in one of the three languages depending on what you are browsing the page with.
  • Make sure the description for the text-input is "Enter the health station's name or address" in what ever language you are viewing the page with.
  • Make sure that the search works with health station name such as "Kalasatama Health Station" but for example the district "Tali" yields no results.
  • Check that code follows our standards.
  • Check testing instructions for the platform configuration changes from the UHF-10555: Deprecated image style cleanup drupal-helfi-platform-config#856 PR.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

Copy link

sonarqubecloud bot commented Dec 3, 2024

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 🚀

@teroelonen teroelonen merged commit 2ebe628 into dev Dec 5, 2024
3 checks passed
@teroelonen teroelonen deleted the UHF-10555 branch December 5, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants