Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10555: Deprecated image style cleanup #780

Merged
merged 7 commits into from
Dec 5, 2024
Merged

UHF-10555: Deprecated image style cleanup #780

merged 7 commits into from
Dec 5, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Dec 2, 2024

UHF-10555

What was done

  • Replace deprecated image style original_l with a new one that is pretty close to the deprecated one on helfi_etusivu.install file.
  • Replace deprecated image style og_image with a new one that is pretty close to the deprecated one on RssEnclosureFormatter.php
  • Remove references (that were not used) to deprecated image style image.style.3_2_m from code.

How to install

  • Make sure your instance is up and running on latest dev branch.
  • make fresh
  • Checkout this feature branch and make sure that helfi_platform config is running on correct branch.
    • git fetch && git checkout UHF-10555
    • composer require drupal/helfi_platform_config:dev-UHF-10555
  • Run make drush-cr drush-cim drush-updb

How to test

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Other PRs

@teroelonen teroelonen changed the title UHF-10555: UHF-10555: Deprecated image style cleanup UHF-10555: Deprecated image style cleanup Dec 3, 2024
@teroelonen teroelonen marked this pull request as ready for review December 4, 2024 14:01
Copy link

sonarqubecloud bot commented Dec 4, 2024

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 🚀

@teroelonen teroelonen merged commit f0844a0 into dev Dec 5, 2024
3 checks passed
@teroelonen teroelonen deleted the UHF-10555 branch December 5, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants