Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-7111: Changed high school and vocational school to use unified ca… #278

Merged
merged 6 commits into from
Feb 3, 2023
Merged

UHF-7111: Changed high school and vocational school to use unified ca… #278

merged 6 commits into from
Feb 3, 2023

Conversation

lonkaanna
Copy link
Contributor

@lonkaanna lonkaanna commented Dec 1, 2022 •
edited by khalima
Loading

…rd styles

UHF-7111

What was done

  • Changed the unit search to use new card styles.

How to install

How to test

  • Check testing instructions form UHF-8004 PR
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

@Arkkimaagi Arkkimaagi marked this pull request as draft December 1, 2022 12:22
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Arkkimaagi Arkkimaagi mentioned this pull request Dec 5, 2022
Merged
8 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@teroelonen teroelonen mentioned this pull request Feb 2, 2023
Merged
4 tasks
@teroelonen teroelonen marked this pull request as ready for review February 2, 2023 13:32
khalima
khalima approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, good to be merged. 🚀

@teroelonen teroelonen merged commit 4457b13 into dev Feb 3, 2023
@teroelonen teroelonen deleted the UHF-7111-kasko-unified-cards branch February 3, 2023 09:57
@teroelonen teroelonen mentioned this pull request Feb 14, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalima khalima khalima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lonkaanna @khalima @teroelonen