Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8075: Fix high school cards linking #308

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Feb 14, 2023

UHF-8075

What was done

  • Re-added functionality that was accidentally removed. The functionality makes it possible to add "front page" for the high schools. If front page is not set and www-page is then the high school cards link to that url. If that is not set either then it should link to unit-page. Before the fix all the cards linked to unit-pages.
  • The PR where the functionality was removed and where you can check how it was implemented earlier: UHF-7111: Changed high school and vocational school to use unified ca… #278

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-8075_fix_high_school_card_linking
    • make fresh
  • Run make drush-cr

How to test

  • Go to https://helfi-kasko.docker.so/en/childhood-and-education/general-upper-secondary-education/general-upper-secondary-schools and make sure the high school cards link to high schools web pages.
  • Go edit one of the high schools and add standard page or landing page to the "High school front page" field. After saving the high school card should link to this page.
  • Check that code follows our standards.

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

… the tpr_unit preprocess so that the high school cards can be linked again to content pages and external pages
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dire dire self-requested a review February 15, 2023 07:30
Copy link
Contributor

@dire dire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described!

@teroelonen teroelonen merged commit a62f24a into dev Feb 16, 2023
@teroelonen teroelonen deleted the UHF-8075_fix_high_school_card_linking branch February 16, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants