-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add helsinki-benefit amount estimate calculator #1045
Conversation
61e0a78
to
94d1a83
Compare
94d1a83
to
25d5f18
Compare
25d5f18
to
c8da1d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nicely done and the tests were a good addition. We should definitely consider adding those ourselves! What I would still ask for you to do is to check my comments on the commented lines if they are still needed and to add the calculator machine name to templates/paragraphs/paragraph--calculator.html.twig
file on line 32. Also this needs to have the minified js added and committed under the dist folder so please add that as well and we can merge this one 🙏
src/js/calculator/helsinki_benefit_amount_estimate/_translations.js
Outdated
Show resolved
Hide resolved
Job's done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very good now 🦖
HL-360 / UHF-10588
What was done
How to install
npm install
cd src/js/calculator/helsinki_benefit_amount_estimate/tests && npm install
How to test
To run manual tests
npm run build
drupal-hdbt/
, for instancepython -m http.server 3001
To run automatic browser tests
This requires test dependencies to be installed
cd src/js/calculator/helsinki_benefit_amount_estimate/tests && npm run test
Continuous documentation
https://helsinkisolutionoffice.atlassian.net/wiki/spaces/HEL/pages/8963751960/Helsinki-lis+n+m+r+n+laskuri
Translations
Screenshot 📸 🖼️