Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10588: Add helsinki_benefit_amount_estimate calculator to the required places #819

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Oct 3, 2024

UHF-10588

What was done

How to install

  • Make sure your instance is up and running on latest dev branch. I recommend testing on ELO since that is were the calculator will come.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-10588
  • Make sure the hdbt-theme is using the latest tag 6.7.7.
  • Go back to project root and run make drush-cr
  • On ELO you can now checkout the feature branch git fetch && git checkout UHF-10588
    • Run make drush-cim drush-cr and you should be ready to skip the next bullet.
  • Now if you are testing with instance that doens't have the calculators enabled we need to turn on the module:
    • make shell
    • drush en helfi_calculator
  • Now log into the site and go to the calculator settings page: /admin/tools/calculator-settings
    • Turn on the Helsinki-lisän arviolaskuri and give it the following configuration and save the settings:
{
  "HELSINKI_BENEFIT_MAX_AMOUNT_WITH_PAY_SUBSIDY": 800,
  "HELSINKI_BENEFIT_MAX_AMOUNT_WITHOUT_PAY_SUBSIDY": 800,
  "PAY_SUBSIDY_PERCENTAGES": [0, 0.5, 0.7],
  "PAY_SUBSIDY_AMOUNT_MAX_LIMIT": [999999, 1260, 1770],
  "STATE_AID_PERCENTAGES": [1, 0.5, 1],
  "SALARY_OTHER_EXPENSES_PERCENTAGE": 0.22
} 

How to test

  • Check that you are able to add the new calculator using a calculator paragraph to a basic page.
  • Make sure the calculator layout works correctly on the page.
  • Check that code follows our standards.

Continuous documentation

  • This feature has been documented/the documentation has been updated in Confluence
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

Copy link

sonarqubecloud bot commented Oct 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants