Support namespace field in parametersRef [ONPREM-591] #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # 101.0.13 | ||
|
|
||
| - [#32](https://github.com/CircleCI-Public/container-runner-helm-chart/pull/32) Add finalizer on GatewayClass to ensure proper cleanup | ||
| - [#33](https://github.com/CircleCI-Public/container-runner-helm-chart/pull/33) Add finalizer on GatewayClass to ensure proper cleanup |
There was a problem hiding this comment.
Linked to the wrong PR before
christian-stephen
force-pushed
the
cs/add-namespace-option-for-parametersref
branch
from
82d5fb2 to
6168670
Compare
Comment on lines
+22
to
+24
| {{- if .namespace }} | ||
| namespace: {{ .namespace }} | ||
| {{- end }} |
There was a problem hiding this comment.
circlery
approved these changes
Nov 24, 2023
soulchips
approved these changes
Nov 24, 2023
christian-stephen
deleted the
cs/add-namespace-option-for-parametersref
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚙️ Issue
Ticket/s: https://circleci.atlassian.net/browse/ONPREM-591
⚙️ Change
ParametersReference supports this field optionally: https://gateway-api.sigs.k8s.io/reference/spec/#gateway.networking.k8s.io%2fv1.ParametersReference
Change Type:
AC:
✅ Fix
❓ Tests
🗒️ Documentation