Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support namespace field in parametersRef [ONPREM-591] #35

Merged
merged 1 commit into from
Nov 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ description: For deploying a CircleCI Container Agent
icon: https://raw.githubusercontent.com/circleci/media/master/logo/build/horizontal_dark.1.png
type: application

version: "101.0.13"
version: "101.0.14"
appVersion: "3"
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

For deploying a CircleCI Container Agent

![Version: 101.0.13](https://img.shields.io/badge/Version-101.0.13-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 3](https://img.shields.io/badge/AppVersion-3-informational?style=flat-square)
![Version: 101.0.14](https://img.shields.io/badge/Version-101.0.14-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 3](https://img.shields.io/badge/AppVersion-3-informational?style=flat-square)

## Contributing

Expand Down
6 changes: 5 additions & 1 deletion changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@

This is the Container Agent Helm Chart changelog

# 101.0.14

- [#34](https://github.com/CircleCI-Public/container-runner-helm-chart/pull/34) Support the namespace field in ParametersReference for the SSH reruns GatewayClass

# 101.0.13

- [#32](https://github.com/CircleCI-Public/container-runner-helm-chart/pull/32) Add finalizer on GatewayClass to ensure proper cleanup
- [#33](https://github.com/CircleCI-Public/container-runner-helm-chart/pull/33) Add finalizer on GatewayClass to ensure proper cleanup
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linked to the wrong PR before


# 101.0.12

Expand Down
3 changes: 3 additions & 0 deletions templates/ssh.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ spec:
group: {{ .group }}
kind: {{ .kind }}
name: {{ .name }}
{{- if .namespace }}
namespace: {{ .namespace }}
{{- end }}
Comment on lines +22 to +24
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{{- end }}

---
Expand Down
5 changes: 5 additions & 0 deletions tests/__snapshot__/ssh_test.yaml.snap
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ should create Gateway and Service resources if enabled:
namespace: NAMESPACE
spec:
controllerName: example.net/gateway-controller
parametersRef:
group: test.group
kind: testKind
name: testName
namespace: testNamespace
2: |
apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
Expand Down
5 changes: 5 additions & 0 deletions tests/ssh_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ tests:
set:
agent.ssh.enabled: true
agent.ssh.controllerName: "example.net/gateway-controller"
agent.ssh.parametersRef:
group: "test.group"
kind: "testKind"
name: "testName"
namespace: "testNamespace"
agent.ssh.startPort: 22
agent.ssh.numPorts: 3
asserts:
Expand Down