Support optional namespace field in parametersRef (#35)

CircleCI-Public · Nov 24, 2023 · c250cf2 · c250cf2
1 parent 50c4658
commit c250cf2
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 3 deletions.
diff --git a/Chart.yaml b/Chart.yaml
@@ -4,5 +4,5 @@ description: For deploying a CircleCI Container Agent
 icon: https://raw.githubusercontent.com/circleci/media/master/logo/build/horizontal_dark.1.png
 type: application
 
-version: "101.0.13"
+version: "101.0.14"
 appVersion: "3"
diff --git a/README.md b/README.md
@@ -2,7 +2,7 @@
 
 For deploying a CircleCI Container Agent
 
-![Version: 101.0.13](https://img.shields.io/badge/Version-101.0.13-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 3](https://img.shields.io/badge/AppVersion-3-informational?style=flat-square)
+![Version: 101.0.14](https://img.shields.io/badge/Version-101.0.14-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 3](https://img.shields.io/badge/AppVersion-3-informational?style=flat-square)
 
 ## Contributing
 

diff --git a/changelog.md b/changelog.md
@@ -2,9 +2,13 @@
 
 This is the Container Agent Helm Chart changelog
 
+# 101.0.14
+
+- [#34](https://github.com/CircleCI-Public/container-runner-helm-chart/pull/34) Support the namespace field in ParametersReference for the SSH reruns GatewayClass
+
 # 101.0.13
 
-- [#32](https://github.com/CircleCI-Public/container-runner-helm-chart/pull/32) Add finalizer on GatewayClass to ensure proper cleanup
+- [#33](https://github.com/CircleCI-Public/container-runner-helm-chart/pull/33) Add finalizer on GatewayClass to ensure proper cleanup
 
 # 101.0.12
 

diff --git a/templates/ssh.yaml b/templates/ssh.yaml
@@ -19,6 +19,9 @@ spec:
     group: {{ .group }}
     kind: {{ .kind }}
     name: {{ .name }}
+    {{- if .namespace }}
+    namespace: {{ .namespace }}
+    {{- end }}
   {{- end }}
 
 ---

diff --git a/tests/__snapshot__/ssh_test.yaml.snap b/tests/__snapshot__/ssh_test.yaml.snap
@@ -9,6 +9,11 @@ should create Gateway and Service resources if enabled:
       namespace: NAMESPACE
     spec:
       controllerName: example.net/gateway-controller
+      parametersRef:
+        group: test.group
+        kind: testKind
+        name: testName
+        namespace: testNamespace
   2: |
     apiVersion: gateway.networking.k8s.io/v1
     kind: Gateway

diff --git a/tests/ssh_test.yaml b/tests/ssh_test.yaml
@@ -5,6 +5,11 @@ tests:
     set:
       agent.ssh.enabled: true
       agent.ssh.controllerName: "example.net/gateway-controller"
+      agent.ssh.parametersRef:
+        group: "test.group"
+        kind: "testKind"
+        name: "testName"
+        namespace: "testNamespace"
       agent.ssh.startPort: 22
       agent.ssh.numPorts: 3
     asserts: