Add finalizer on GatewayClass to ensure proper cleanup (#33)

* Add finalizer on GatewayClass to ensure proper cleanup * Bump version and update changelog
CircleCI-Public · Nov 23, 2023 · 50c4658 · 50c4658
1 parent f3376fd
commit 50c4658
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 2 deletions.
diff --git a/Chart.yaml b/Chart.yaml
@@ -4,5 +4,5 @@ description: For deploying a CircleCI Container Agent
 icon: https://raw.githubusercontent.com/circleci/media/master/logo/build/horizontal_dark.1.png
 type: application
 
-version: "101.0.12"
+version: "101.0.13"
 appVersion: "3"
diff --git a/README.md b/README.md
@@ -2,7 +2,7 @@
 
 For deploying a CircleCI Container Agent
 
-![Version: 101.0.12](https://img.shields.io/badge/Version-101.0.12-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 3](https://img.shields.io/badge/AppVersion-3-informational?style=flat-square)
+![Version: 101.0.13](https://img.shields.io/badge/Version-101.0.13-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 3](https://img.shields.io/badge/AppVersion-3-informational?style=flat-square)
 
 ## Contributing
 

diff --git a/changelog.md b/changelog.md
@@ -2,6 +2,10 @@
 
 This is the Container Agent Helm Chart changelog
 
+# 101.0.13
+
+- [#32](https://github.com/CircleCI-Public/container-runner-helm-chart/pull/32) Add finalizer on GatewayClass to ensure proper cleanup
+
 # 101.0.12
 
 - [#31](https://github.com/CircleCI-Public/container-runner-helm-chart/pull/31) Fixed PDB to reference the right variable

diff --git a/templates/ssh.yaml b/templates/ssh.yaml
@@ -10,6 +10,8 @@ kind: GatewayClass
 metadata:
   name: {{ $name }}
   namespace: {{ $namespace }}
+  finalizers:
+    - gateway-exists-finalizer.gateway.networking.k8s.io
 spec:
   controllerName: {{ .Values.agent.ssh.controllerName }}
   {{- with .Values.agent.ssh.parametersRef }}

diff --git a/tests/__snapshot__/ssh_test.yaml.snap b/tests/__snapshot__/ssh_test.yaml.snap
@@ -3,6 +3,8 @@ should create Gateway and Service resources if enabled:
     apiVersion: gateway.networking.k8s.io/v1
     kind: GatewayClass
     metadata:
+      finalizers:
+        - gateway-exists-finalizer.gateway.networking.k8s.io
       name: RELEASE-NAME-container-agent-ssh
       namespace: NAMESPACE
     spec: