Add more checks on whether the note is correct #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably a bit more context, the source firing for all midi id was probably always present, and it was caught by this line before the migration, which is now removed: FreeShow/src/frontend/utils/midi.ts Line 124 in ce0141d |
|
Great! Thanks. :) |
|
My bad that I didn't follow the naming convention. @vassbo, I can clean it up or if you prefer to clean it up yourselves, please do so. |
|
No worries @ip4368, shouldn't be a problem. |
vassbo
added a commit
that referenced
this pull request
Jun 26, 2024
* 🚩 Updated languages * ✨ Optimization - Consistent saving - Better organization & naming - Better startup - Playlist names decoded * 🎨 Custom border radius - Fixed some freeze errors - Tweaked settings * ⏱ Metronome * ✨ Start metronome from slide - Drop actions to slide - Fixed new items getting removed if not in selected template - Special textboxes are removed when changing template - Text editor will select the best textbox - List view textboxes in correct oreder - Text editor not removing extra items * Issue #501 Fix (#576) * Show search results * Select songs from search results * Added hymnary * Updated toast message and added error handling. * 🔍 Added Svelte inspector * Optimized media (#586) * 🖼 New handling of thumbnails - New virtual grid * 🖼 Enhancements - Fixed jpg thumbnails - Fixed media loader - Less lag when scrolling * ✔ Removed unused code * ✨ Improved media loading - Slide & stage cache working with the new system - Removed old mediaCache * 🖼 Changed from ffmpeg to custom capturer * 🖼 Faster Media Thumbnails - Fixed gif, webp & mov not working - Uppercase filenames working - Editor thumbnails * ✔ Fixed receivers * ✔ Improved OpenLP parser - Fixed OpenLP songs sometimes not arranged after order - Fixed API Bible not loading - Updated Show search style * Add more checks on whether the note is correct (#591) * ✨ Optimizations - Removed Svelte inspector from prod - Organized code - Preload script map * 📦 SoftProjector importing * ✔ Lots of bugfixes - Fixed timer becoming imprecise - Fixed timer not starting when "Start show" action was triggered - Fixed output not always getting data - Fixed empty action not removed - Fixed Cloud syncing on save and not close - Better sync indication - Stage align & CSS edit - Fixed an error with video transition - Media item thumbnail - Fixed cut in two not working when having multiple textboxes - Media select outline - Align with screen trigger - Toggle to allow output on main screen - Removed some special VideoPsalm tags - Scripture content search has more results * Custom linux arm64 build (#602) * 📦 Custom Linux arm64 build * Updated checkout to v3 & node to 20 * ✔ Removed capture window to remove save dialog sometimes * ✨ Template slide values - Template background & overlay - Custom first slide template - Scripture auto scroll - Fixed playing audio title - OpenLyrics multiple lines tag support - Video volume working again - Change video gain - Improved clearing per output - Window miminum size - Better preview fps - Fixed freeze when slide background was not found - Fixed loop sometimes when setting template - Set video in styles * ✨ Template actions - Template add overlays - Fixed background sometimes not pausing - Custom action activation - Scripture verses on individual lines - Fixed empty scripture preview - Export/import themes & templates - Updated import popup - Reduced import image sizes * Making test to be independent from what was on the existing setup (#605) * Now execute with bash cmd: FS_MOCK_STORE_PATH=/var/folders/xq/hbb976490kjf8s2lxkj0c3xh0000gn/T/tmp.WBSw8XuU8h bash -c 'npm run test && rm -rf ' * Add timeout to actions * Add a screenshot around assert * Update start.test.ts * improve test * make alert ack optional * make npm run test to use tmp dir * Delete test-output/screenshots/failed.png * Update .gitignore to ignore test output dirs * the test should finally be quite stable, and not depends on existing setup * cleaning up minor issues and refactor a little bit * remove unnessary data-testid * fix var naming convension * 🚩 Updated languages * 🔗 Updated repo paths * Add playwright config and github worklow to run e2e test (#606) * add playwright config and github worklow to run e2e test * Add dev branch E2E test status to README.md * Update README.md * 🔊 Audio crossfade - Mute audio when video is playing - Next playlist track action - Start action on video start/end - Changed schedule show to schedule action in calendar * 🎵 Fixed slide play MIDI * 📝 Live captions - Better shows search - Shows loading if not loaded when MIDI triggered - Precise timer interval - Drop media on template - Fixed scripture issues * ✨ Variable dynamic values - Fixed Remote issues - Fixed chords when line break - Enable/disable actions - Toggle actions action - Scripture reference align * ✨ UI enhancements - Group templates - Slide template can update without a show template - You can now delete files synced to drive - Fixed caret resetting when line is removed - Bug fixes * ✔ Fixed Lessons.church - Tweaked media cache - Fade out video audio * Version update --------- Co-authored-by: Jeremy Zongker <[email protected]> Co-authored-by: Daniel Ip <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why on MacOS, it seems to repeat the same note for all the Midi id, and if we are not checking the channel/note, it will go crazy and execute basically available action.
This add the checks for channel and note, so that it will only fire if the channel and note are matching the action. Not sure if this is the right fix, or if something can be fix on the midi initial dispatching.