Skip to content

Commit

Permalink
Add more checks on whether the note is correct (#591)
Browse files Browse the repository at this point in the history
  • Loading branch information
ip4368 authored Jun 18, 2024
1 parent b52c8ae commit ef71b8b
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/frontend/components/actions/midi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,10 @@ export function receivedMidi(msg) {

// the select slide index from velocity can't select slide 0 as a NoteOn with velocity 0 is detected as NoteOff
// velocity of 0 currently bypasses the note on/off
if (action.midi?.type !== msg.type && index !== 0) return
const diff_type = action.midi?.type !== msg.type
const diff_note = msg.values.note !== action.midi?.values.note
const diff_channel = msg.values.channel !== action.midi?.values.channel
if ((diff_type || diff_note || diff_channel) && index !== 0) return

let hasindex = action.triggers?.[0]?.includes("index_") ?? false
if (hasindex && index < 0) {
Expand Down

0 comments on commit ef71b8b

Please sign in to comment.