Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more checks on whether the note is correct #591

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Add more checks on whether the note is correct #591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/frontend/components/actions/midi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,10 @@ export function receivedMidi(msg) {

// the select slide index from velocity can't select slide 0 as a NoteOn with velocity 0 is detected as NoteOff
// velocity of 0 currently bypasses the note on/off
if (action.midi?.type !== msg.type && index !== 0) return
const diff_type = action.midi?.type !== msg.type
const diff_note = msg.values.note !== action.midi?.values.note
const diff_channel = msg.values.channel !== action.midi?.values.channel
if ((diff_type || diff_note || diff_channel) && index !== 0) return

let hasindex = action.triggers?.[0]?.includes("index_") ?? false
if (hasindex && index < 0) {
Expand Down