-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHIA-504] Add support for external signers (PLEASE SQUASH) #18199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3e3b630fbd507c607fe7' into quex.signer_protocol
github-actions
bot
added
coverage-diff
merge_conflict
Branch has conflicts that prevent merge to main
labels
Jun 18, 2024
github-actions
bot
removed
the
merge_conflict
Branch has conflicts that prevent merge to main
label
Jun 20, 2024
github-actions
bot
added
the
merge_conflict
Branch has conflicts that prevent merge to main
label
Jun 24, 2024
github-actions
bot
removed
the
merge_conflict
Branch has conflicts that prevent merge to main
label
Jun 25, 2024
markelrod
approved these changes
Jun 25, 2024
|
This PR is waiting on an override of the coverage diff. |
coverage exceptions are fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "catchup" from
long_lived/vault
containing all of the features necesary to support external signers according to CHIPs 27-31. The RPC support was already in place, but this pipes that functionality through to the command line and allows the wallet to act as a signer for transactions generated by other, potentially observer wallets.It's important to squash this PR because I made a series of
[UNDO]
commits on top of the history oflong_lived/vault
in order to separate out the changes I didn't want. In this way the long_lived process hopefully has more weight than when I squashed a bit of it preemptively in an earlier "catchup". If this PR is not squashed when it's merged, then the next catchup to the vault branch will essentially eliminate its diff because there are later changes that undo stuff that has already been done.The following PRs into
long_lived/vault
are included:chia wallet send
to @tx_out_cmd #18002chia wallet coins
to @tx_out_cmd #18023chia wallet clawback
to @tx_out_cmd #18036chia wallet take/cancel_offer
to @tx_out_cmd #18038chia wallet did ...
to @tx_out_cmd #18041chia wallet nft ...
to @tx_out_cmd #18044chia wallet notifications send
to @tx_out_cmd #18047chia wallet vcs ...
to @tx_out_cmd #18062chia dao ...
to @tx_out_cmd (and exclude DL and pooling) #18065chia wallet signer
commands #17399