Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-432] Port chia dao ... to @tx_out_cmd (and exclude DL and pooling) #18065

Merged
merged 3 commits into from
May 23, 2024

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington commented May 22, 2024

This brings another set of commands to the @tx_out_cmd decorator which gives it the capability to optionally push a transaction and export the transactions to a local file.

This PR being the last in a chain of similar PRs, I have included some comments explaining that DL and pooling endpoints will not be ported to the decorator at this time. Didn't think that necessitated its own PR and CI run :)

@Quexington Quexington changed the title Port chia dao ... to @tx_out_cmd [CHIA-432] Port chia dao ... to @tx_out_cmd May 22, 2024
@Quexington Quexington added Added Required label for PR that categorizes merge commit message as "Added" for changelog vault labels May 22, 2024
@Quexington Quexington changed the title [CHIA-432] Port chia dao ... to @tx_out_cmd [CHIA-432] Port chia dao ... to @tx_out_cmd (and exclude DL and pooling) May 22, 2024
@Quexington Quexington marked this pull request as ready for review May 22, 2024 19:40
@Quexington Quexington requested a review from a team as a code owner May 22, 2024 19:40
@Quexington Quexington requested a review from emlowe May 23, 2024 14:04
Copy link
Contributor

File Coverage Missing Lines
chia/cmds/dao_funcs.py 81.2% lines 176-178, 332-334, 371-373, 408-409, 411, 443-445, 479-481
Total Missing Coverage
119 lines 18 lines 84%

Copy link

Pull Request Test Coverage Report for Build 9198451806

Details

  • 101 of 119 (84.87%) changed or added relevant lines in 2 files are covered.
  • 16 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.006%) to 90.875%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/cmds/dao_funcs.py 78 96 81.25%
Files with Coverage Reduction New Missed Lines %
chia/daemon/keychain_proxy.py 1 72.96%
chia/rpc/rpc_server.py 1 87.71%
chia/farmer/farmer.py 1 72.23%
chia/wallet/wallet_node.py 1 88.9%
chia/timelord/timelord_launcher.py 1 69.92%
chia/daemon/client.py 1 73.33%
chia/timelord/timelord.py 2 73.67%
chia/server/node_discovery.py 4 79.26%
chia/server/server.py 4 81.46%
Totals Coverage Status
Change from base Build 9195781447: -0.006%
Covered Lines: 99890
Relevant Lines: 109870

💛 - Coveralls

@Quexington Quexington merged commit 7424942 into long_lived/vault May 23, 2024
359 of 362 checks passed
@Quexington Quexington deleted the quex.port_dao_cmds_to_tx_out_cmd branch May 23, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog coverage-diff vault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants